From: Jiang Liu <liuj97@gmail.com>
To: shuahkhan@gmail.com
Cc: Toshi Kani <toshi.kani@hp.com>,
lenb@kernel.org, linux-acpi@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/5] ACPI: Add _OST support for ACPI hotplug
Date: Fri, 13 Apr 2012 22:24:29 +0800 [thread overview]
Message-ID: <4F88371D.7030305@gmail.com> (raw)
In-Reply-To: <1334240353.2222.3.camel@lorien2>
Hi Shuah and Toshi,
As I can tell, _OST method has been defined in ACPI4.0 spec and
there are some platforms already implemented the _OST method. For example,
Quanta QSSC-S4R server implements _OST for hot-pluggable PCI slots, but
it's a little pity that it doesn't implement _OST for the memory board,
so we can't test Toshi's patch on that platform.
According to my understanding, other than notifying BIOS about the
event processing result, _OST could also be used to notify BIOS about the
IN_PROGRESS state, so BIOS could track the event handling progress and avoid
timeout. We have used _OST method to avoid timeout on one of our prototype
platforms.
On 04/12/2012 10:19 PM, Shuah Khan wrote:
>
>> Hi Shuah,
>>
>> The fake _OST methods print arguments to verify successful execution of
>> the methods. Since the purpose of _OST is firmware-internal
>> communication, there is no difference in testing on real firmware from
>> the OS perspective. Overriding DSDT with fake ACPI methods is a
>> well-established and widely used testing method as well.
>
> Toshi,
>
> This patch hasn't gone through sufficient new functionality testing as
> the only testing that was done was exercising it with stubbed out
> firmware calls. I am not clear on how much regression testing this patch
> has undergone. Sorry, it doesn't give me the warm and fuzzies.
>
> -- Shuah
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2012-04-13 14:24 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-10 22:21 [PATCH 0/5] ACPI: Add _OST support for ACPI hotplug Toshi Kani
2012-04-10 22:21 ` [PATCH 1/4] ACPI: Set hotplug _OST support bit to _OSC Toshi Kani
2012-04-26 15:16 ` Bjorn Helgaas
2012-04-26 15:16 ` Bjorn Helgaas
2012-04-26 17:10 ` Toshi Kani
2012-04-27 22:05 ` Toshi Kani
2012-05-02 21:20 ` Toshi Kani
2012-04-10 22:21 ` [PATCH 2/4] ACPI: Add acpi_evaluate_ost() for calling _OST Toshi Kani
2012-04-10 22:21 ` [PATCH 3/4] ACPI: Add _OST support for ACPI CPU hotplug Toshi Kani
2012-04-26 15:22 ` Bjorn Helgaas
2012-04-26 15:22 ` Bjorn Helgaas
2012-04-26 17:20 ` Toshi Kani
2012-04-10 22:21 ` [PATCH 4/4] ACPI: Add _OST support for ACPI memory hotplug Toshi Kani
2012-04-11 16:33 ` [PATCH 0/5] ACPI: Add _OST support for ACPI hotplug Shuah Khan
2012-04-11 18:50 ` Toshi Kani
2012-04-12 14:19 ` Shuah Khan
2012-04-13 14:24 ` Jiang Liu [this message]
2012-04-13 15:23 ` Shuah Khan
2012-04-13 16:05 ` Toshi Kani
2012-04-13 18:34 ` Shuah Khan
2012-04-16 18:24 ` Toshi Kani
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F88371D.7030305@gmail.com \
--to=liuj97@gmail.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=shuahkhan@gmail.com \
--cc=toshi.kani@hp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.