From: Adam Jackson <ajax@redhat.com>
To: dri-devel@lists.freedesktop.org
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 5/7] drm/edid: Armor drm_dmt_modes_for_range for reduced blanking modes
Date: Fri, 13 Apr 2012 15:22:46 -0400 [thread overview]
Message-ID: <4F887D06.5060602@redhat.com> (raw)
In-Reply-To: <1334266560-27813-6-git-send-email-ajax@redhat.com>
On 4/12/12 5:35 PM, Adam Jackson wrote:
> @@ -1030,6 +1026,10 @@ drm_dmt_modes_for_range(struct drm_connector *connector, struct edid *edid,
>
> for (i = 0; i< drm_num_dmt_modes; i++) {
> if (mode_in_range(drm_dmt_modes + i, edid, timing)) {
> + if (mode_is_rb(&drm_dmt_modes[i])&&
> + !drm_monitor_supports_rb(edid))
> + continue;
> +
> newmode = drm_mode_duplicate(dev,&drm_dmt_modes[i]);
> if (newmode) {
> drm_mode_probed_add(connector, newmode);
This chunk is actually unnecessary, upon second reading.
mode_in_range() already checks this.
New series in a moment that addresses the extra mode list from HP.
- ajax
next prev parent reply other threads:[~2012-04-13 19:22 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-12 21:35 [PATCH 0/7] drm/edid: Add the reduced-blanking modes to the DMT list Adam Jackson
2012-04-12 21:35 ` [PATCH 1/7] drm/edid: Document drm_mode_find_dmt Adam Jackson
2012-04-12 21:35 ` [PATCH 2/7] drm/edid: Rewrite drm_mode_find_dmt search loop Adam Jackson
2012-04-12 21:35 ` [PATCH 3/7] drm/edid: Allow drm_mode_find_dmt to hunt for reduced-blanking modes Adam Jackson
2012-04-12 21:35 ` [PATCH 4/7] drm/edid: s/drm_gtf_modes_for_range/drm_dmt_modes_for_range/ Adam Jackson
2012-04-12 21:35 ` [PATCH 5/7] drm/edid: Armor drm_dmt_modes_for_range for reduced blanking modes Adam Jackson
2012-04-13 19:22 ` Adam Jackson [this message]
2012-04-12 21:35 ` [PATCH 6/7] drm/edid: Add the reduced blanking DMT modes to the DMT list Adam Jackson
2012-04-12 21:36 ` [PATCH 7/7] drm/edid: Fix some comment typos in the DMT mode list Adam Jackson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F887D06.5060602@redhat.com \
--to=ajax@redhat.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.