All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sakari Ailus <sakari.ailus@iki.fi>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: linux-media@vger.kernel.org
Subject: Re: [yavta PATCH 1/3] Support integer menus.
Date: Fri, 13 Apr 2012 23:13:35 +0300	[thread overview]
Message-ID: <4F8888EF.6040904@iki.fi> (raw)
In-Reply-To: <2967674.Tm7K8VO7YX@avalon>

Hi Laurent,

Thanks for the comments.

Laurent Pinchart wrote:
> Hi Sakari,
>
> Thanks for the patch.
>
> The code looks fine, but unfortunately breaks compilation when using kernel
> headers<  v3.5 (which is a pretty common case as of today ;-)).
>
> V4L2_CTRL_TYPE_INTEGER_MENU is an enumerated value, not a pre-processor
> #define, so it's difficult to test for it using conditional compilation.
>
> Maybe including a copy of videodev2.h in the yavta repository is the best
> option ?

Yeah; I agree. The value of the enum item we could still #define but the 
addition of the union to v4l2_queryctrl is more difficult.

I can then remove existing code to cope with different versions of 
videodev2.h, too.

Cheers,

-- 
Sakari Ailus
sakari.ailus@iki.fi

      parent reply	other threads:[~2012-04-13 20:13 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-12  8:41 [yavta PATCH 1/3] Support integer menus Sakari Ailus
2012-04-12  8:41 ` [yavta PATCH 2/3] Support extended controls, including 64-bit integers Sakari Ailus
2012-04-12  8:41 ` [yavta PATCH 3/3] Support additional dpcm compressed bayer formats Sakari Ailus
2012-04-13 19:17   ` Laurent Pinchart
2012-04-13 20:14     ` Sakari Ailus
2012-04-13 19:47 ` [yavta PATCH 1/3] Support integer menus Laurent Pinchart
2012-04-13 19:57   ` Rémi Denis-Courmont
2012-04-13 20:13   ` Sakari Ailus [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F8888EF.6040904@iki.fi \
    --to=sakari.ailus@iki.fi \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=linux-media@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.