From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757359Ab2DMXW6 (ORCPT ); Fri, 13 Apr 2012 19:22:58 -0400 Received: from mail.redfish-solutions.com ([66.232.79.143]:59379 "EHLO mail.redfish-solutions.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755954Ab2DMXW5 (ORCPT ); Fri, 13 Apr 2012 19:22:57 -0400 Message-ID: <4F88B54C.5050908@redfish-solutions.com> Date: Fri, 13 Apr 2012 16:22:52 -0700 From: Philip Prindeville User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.7; rv:11.0) Gecko/20120327 Thunderbird/11.0.1 MIME-Version: 1.0 To: Bjarke Istrup Pedersen CC: linux-kernel@vger.kernel.org Subject: Re: [PATCH] NET5501: Change active_low to 0 for LED driver. References: <1334101538-19127-1-git-send-email-gurligebis@gentoo.org> <4F88A660.8040304@redfish-solutions.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 4/13/12 3:33 PM, Bjarke Istrup Pedersen wrote: > 14. apr. 2012 00.19 skrev Philip Prindeville > : >> On 4/13/12 3:17 PM, Bjarke Istrup Pedersen wrote: >>> 11. apr. 2012 01.45 skrev Bjarke Istrup Pedersen : >>>> It seems that there was an error with the active_low = 1 for the >>>> LED, since it should be set to 0 (meaning that active is high, >>>> since 0 is false, hence the confusion. >>>> >>>> The wiki article about it confuses it, since it contradicts >>>> itself, regarding what turns on the LED. >>>> >>>> I have tested 3.4-rc2 on my net5501 with this patch, and it >>>> makes the LED behave correctly, where "none" turns it off, and >>>> "default-on" turns it on, when echoed onto the trigger "file" >>>> in /sys/class/leds. >>>> >>>> Signed-off-by: Bjarke Istrup Pedersen >>>> --- >>>> arch/x86/platform/geode/net5501.c | 2 +- >>>> 1 files changed, 1 insertions(+), 1 deletions(-) >>>> >>>> diff --git a/arch/x86/platform/geode/net5501.c b/arch/x86/platform/geode/net5501.c >>>> index 66d377e..646e3b5 100644 >>>> --- a/arch/x86/platform/geode/net5501.c >>>> +++ b/arch/x86/platform/geode/net5501.c >>>> @@ -63,7 +63,7 @@ static struct gpio_led net5501_leds[] = { >>>> .name = "net5501:1", >>>> .gpio = 6, >>>> .default_trigger = "default-on", >>>> - .active_low = 1, >>>> + .active_low = 0, >>>> }, >>>> }; >>>> >>>> -- >>>> 1.7.8.5 >>>> >>> I have tried sending it to linux-geode, but the list seems to reject >>> mails from me for some reason. >>> Anyone able to forward it to the right people for inclusion in 3.4-rcX ? >>> >>> Thanks in advance, >>> Bjarke >> The linux-geode list is currently buggered and without an owner, as far as I know. >> >> -Philip > That would explain it :) > > Do you have a chance to push it upstream, like your changes? (Not sure > who I should poke about it) > > /Bjarke > I'd copy it to Andrew Morton, and maybe also platform-driver-x86@vger.kernel.org ... -Philip