From: "Arend van Spriel" <arend@broadcom.com>
To: "Hauke Mehrtens" <hauke@hauke-m.de>
Cc: "nbowler@elliptictech.com" <nbowler@elliptictech.com>,
"linville@tuxdriver.com" <linville@tuxdriver.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
"zajec5@gmail.com" <zajec5@gmail.com>
Subject: Re: [PATCH] bcma: use fallback sprom if no on chip sprom is available
Date: Mon, 16 Apr 2012 11:01:27 +0200 [thread overview]
Message-ID: <4F8BDFE7.5070501@broadcom.com> (raw)
In-Reply-To: <1334407134-22803-1-git-send-email-hauke@hauke-m.de>
On 04/14/2012 02:38 PM, Hauke Mehrtens wrote:
> bcma should check for a fallback sprom every time it can not find a
> sprom on the card itself or a normal external sprom mapped into the
> memory of the chip. When otp sprom support was introduced it tried to
> read out the sprom from the wireless chip also if no otp sprom was
> available. This caused a Data bus error in bcma_sprom_get() when
> reading out the sprom for the SoC.
>
> This fixes a regression introduced in commit:
>
> commit 10d8493cd9efd38b1947b7a74276dbdc8311aa1a
> Author: Arend van Spriel<arend@broadcom.com>
> Date: Tue Mar 6 15:50:48 2012 +0100
>
> bcma: add support for on-chip OTP memory used for SPROM storage
>
> This patch was tested on a Netgear WNDR3400 (Broadcom BCM4718 SoC).
>
> Reported-by: Nick Bowler<nbowler@elliptictech.com>
Acked-by: Arend van Spriel <arend@broadcom.com>
> Signed-off-by: Hauke Mehrtens<hauke@hauke-m.de>
Thanks for fixing this. I really need to get my bcm4718 soc up and
running ;-)
Gr. AvS
prev parent reply other threads:[~2012-04-16 9:01 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-14 2:44 Regression: bcma: early boot crash on BCM4716 w/ 3.4-rc2+ (bisected) Nick Bowler
2012-04-14 12:38 ` [PATCH] bcma: use fallback sprom if no on chip sprom is available Hauke Mehrtens
2012-04-14 19:01 ` Nick Bowler
2012-04-16 9:01 ` Arend van Spriel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F8BDFE7.5070501@broadcom.com \
--to=arend@broadcom.com \
--cc=hauke@hauke-m.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=nbowler@elliptictech.com \
--cc=zajec5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.