All of lore.kernel.org
 help / color / mirror / Atom feed
From: Felix Fietkau <nbd@openwrt.org>
To: Daniel Halperin <dhalperi@cs.washington.edu>
Cc: linux-wireless@vger.kernel.org, linville@tuxdriver.com,
	mcgrof@qca.qualcomm.com
Subject: Re: [PATCH 2/9] ath9k_hw: do not override SIFS time for half/quarter channels
Date: Mon, 16 Apr 2012 11:44:45 +0200	[thread overview]
Message-ID: <4F8BEA0D.9020104@openwrt.org> (raw)
In-Reply-To: <CALSq=BZMi0Tc+7paCi_Fid5hurXVxBCROe3xOzpP+o1BW1EBQA@mail.gmail.com>

On 2012-04-16 8:30 AM, Daniel Halperin wrote:
> On Sun, Apr 15, 2012 at 11:27 AM, Felix Fietkau <nbd@openwrt.org> wrote:
>> On 2012-04-15 8:22 PM, Daniel Halperin wrote:
>>> Felix,
>>>
>>> This whole patch series throws the NICs out of spec compliance. For
>>> instance, page 626 of the 802.11-2007 standard (Table 17-15) says that
>>> aSIFStime is 32 us in 10 MHz mode and 64 us in 5 MHz mode.
>>>
>>> This might be okay to do for certain implementations (as, apparently,
>>> AR9280/AR9380), but will break compatibility with any device obeying
>>> the standard instead.
>>>
>>> (I wonder that, if this code below still works, then it seems that you
>>> might not be properly downclocking the chips' reference clock...)
>>>
>>> Are you aware there's a standard for this? Why violate it?
>> I'm aware that there's a standard for it, but if I put in the standard
>> values, the connection gets unreliable to the point where it's almost
>> unusable. That's why I chose to use existing products with 5/10 MHz
>> support as reference instead.
>>
> 
> I hear you, but still suspect the bug's somewhere else. Violating the
> standard likely isn't the right choice unless you have a good
> reason... it sounds like you don't know why this is happening but this
> hack 'seems to work'.
> 
> (UBNT is also ath-based, right? So it's not really proof that this
> hack doesn't break compatibility..)
Right, UBNT is also ath-based, and I dumped the registers on the device
to figure out what parameters they were using, and used those as
reference for my ath9k work.
I'm not aware of *any* standard compliant 5/10 MHz product out there, do
you know any?

- Felix

  reply	other threads:[~2012-04-16  9:44 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-15 10:15 [PATCH 1/9] ath9k_hw: use lower rx latency values for half/quarter channels Felix Fietkau
2012-04-15 10:15 ` [PATCH 2/9] ath9k_hw: do not override SIFS time " Felix Fietkau
2012-04-15 10:15   ` [PATCH 3/9] ath9k_hw: set the PHY mode for half/quarter channels on AR9003 Felix Fietkau
2012-04-15 10:15     ` [PATCH 4/9] ath9k_hw: increase symbol overlap window for half/quarter channels Felix Fietkau
2012-04-15 10:15       ` [PATCH 5/9] ath9k_hw: fix and clean up PHY activation delay Felix Fietkau
2012-04-15 10:15         ` [PATCH 6/9] ath9k_hw: increase ACK timeout for half/quarter channels Felix Fietkau
2012-04-15 10:15           ` [PATCH 7/9] ath9k_hw: disable Tx IQ calibration on " Felix Fietkau
2012-04-15 10:15             ` [PATCH 8/9] ath9k_hw: disable fast channel change when changing from/to half/quarter mode Felix Fietkau
2012-04-15 10:15               ` [PATCH 9/9] ath9k_hw: increase tx abort timeout for half/quarter channels Felix Fietkau
2012-04-15 18:22   ` [PATCH 2/9] ath9k_hw: do not override SIFS time " Daniel Halperin
2012-04-15 18:27     ` Felix Fietkau
2012-04-16  6:30       ` Daniel Halperin
2012-04-16  9:44         ` Felix Fietkau [this message]
2012-04-16 13:16           ` Felix Fietkau

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F8BEA0D.9020104@openwrt.org \
    --to=nbd@openwrt.org \
    --cc=dhalperi@cs.washington.edu \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    --cc=mcgrof@qca.qualcomm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.