All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Ward, David - 0663 - MITLL" <david.ward@ll.mit.edu>
To: "netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: [PATCH] net_sched: red: Make minor corrections to comments
Date: Mon, 16 Apr 2012 09:06:02 -0400	[thread overview]
Message-ID: <4F8C193A.5090806@ll.mit.edu> (raw)
In-Reply-To: <1334529106-5035-2-git-send-email-david.ward@ll.mit.edu>

On 04/15/2012 06:31 PM, Ward, David - 0663 - MITLL wrote:
> diff --git a/include/net/red.h b/include/net/red.h
> index 77d4c37..c0bc25e 100644
> --- a/include/net/red.h
> +++ b/include/net/red.h
> @@ -28,7 +28,7 @@
>   	the inertia of the algorithm. To allow larger bursts, W should be
>   	decreased.
>
> -	if (avg>  th_max) ->  packet marked (dropped).
> +	if (avg>  th_max) ->  packet marked (dropped) with probability max_P.
>   	if (avg<  th_min) ->  packet passes.
>   	if (th_min<  avg<  th_max) we calculate probability:
>
Sorry, this line was correct as it was. (Misleading man page tc-red(8) 
says "Because probability is normally not set to 100%, the queue size 
might conceivably rise above max bytes")

Re-sending with just the other changes (and a patch for that man page).

  reply	other threads:[~2012-04-16 13:06 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-15 22:31 [PATCH] net_sched: gred: Fix oops in gred_dump() in WRED mode David Ward
2012-04-15 22:31 ` [PATCH] net_sched: red: Make minor corrections to comments David Ward
2012-04-16 13:06   ` Ward, David - 0663 - MITLL [this message]
2012-04-16 13:17     ` [PATCH v2] " David Ward
2012-04-17  3:53       ` David Miller
2012-04-17  3:51 ` [PATCH] net_sched: gred: Fix oops in gred_dump() in WRED mode David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F8C193A.5090806@ll.mit.edu \
    --to=david.ward@ll.mit.edu \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.