From: Shubhrajyoti <shubhrajyoti@ti.com>
To: Tarun Kanti DebBarma <tarun.kanti@ti.com>
Cc: linux-omap@vger.kernel.org, tony@atomide.com, khilman@ti.com,
paul@pwsan.com, b-cousson@ti.com, santosh.shilimkar@ti.com,
rnayak@ti.com
Subject: Re: [PATCH 1/3] ARM: OMAP: dmtimer: Use devm_ API and do some cleanup in probe()
Date: Mon, 16 Apr 2012 20:32:07 +0530 [thread overview]
Message-ID: <4F8C346F.9020200@ti.com> (raw)
In-Reply-To: <1334579125-15566-2-git-send-email-tarun.kanti@ti.com>
On Monday 16 April 2012 05:55 PM, Tarun Kanti DebBarma wrote:
> Replace the regular kzalloc and ioremap with the devm_ equivalent
> to simplify error handling. We don't need kree() anymore in
> omap_dm_timer_remove().
>
> Also added *dev* pointer to reference pdev->dev which makes the
> usage shorter in code.
>
> Signed-off-by: Tarun Kanti DebBarma <tarun.kanti@ti.com>
> ---
>
<snip>
> - timer->io_base = ioremap(mem->start, resource_size(mem));
> + timer->io_base = devm_ioremap(dev, mem->start, resource_size(mem));
> if (!timer->io_base) {
Could we use devm_request_and_ioremap here?
next prev parent reply other threads:[~2012-04-16 15:02 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-16 12:25 [PATCH 0/3] ARM: OMAP2+: dmtimer: cleanup related to devm API and clk usage Tarun Kanti DebBarma
2012-04-16 12:25 ` [PATCH 1/3] ARM: OMAP: dmtimer: Use devm_ API and do some cleanup in probe() Tarun Kanti DebBarma
2012-04-16 15:02 ` Shubhrajyoti [this message]
2012-04-17 5:01 ` DebBarma, Tarun Kanti
2012-04-16 12:25 ` [PATCH 2/3] ARM: OMAP2+: dmtimer: cleanup iclk usage Tarun Kanti DebBarma
2012-04-16 15:03 ` Hiremath, Vaibhav
2012-04-16 19:12 ` DebBarma, Tarun Kanti
2012-04-16 19:17 ` Hiremath, Vaibhav
2012-04-16 19:27 ` Paul Walmsley
2012-04-16 19:50 ` Hiremath, Vaibhav
2012-04-16 16:45 ` Paul Walmsley
2012-04-16 16:50 ` Paul Walmsley
2012-04-16 19:26 ` DebBarma, Tarun Kanti
2012-04-16 19:29 ` Paul Walmsley
2012-04-16 19:30 ` Paul Walmsley
2012-04-16 19:34 ` DebBarma, Tarun Kanti
2012-04-16 12:25 ` [PATCH 3/3] ARM: OMAP2+: dmtimer: cleanup fclk usage Tarun Kanti DebBarma
2012-04-16 16:40 ` Paul Walmsley
2012-04-16 20:51 ` Cousson, Benoit
2012-04-18 5:00 ` DebBarma, Tarun Kanti
2012-04-18 8:15 ` Paul Walmsley
2012-04-18 8:19 ` DebBarma, Tarun Kanti
2012-04-16 14:53 ` [PATCH 0/3] ARM: OMAP2+: dmtimer: cleanup related to devm API and clk usage Hiremath, Vaibhav
2012-04-16 19:50 ` DebBarma, Tarun Kanti
2012-04-16 19:53 ` Hiremath, Vaibhav
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F8C346F.9020200@ti.com \
--to=shubhrajyoti@ti.com \
--cc=b-cousson@ti.com \
--cc=khilman@ti.com \
--cc=linux-omap@vger.kernel.org \
--cc=paul@pwsan.com \
--cc=rnayak@ti.com \
--cc=santosh.shilimkar@ti.com \
--cc=tarun.kanti@ti.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.