From mboxrd@z Thu Jan 1 00:00:00 1970 From: swarren@wwwdotorg.org (Stephen Warren) Date: Mon, 16 Apr 2012 12:05:28 -0600 Subject: [PATCH V3 4/4] SPEAr3xx: Add pinctrl support for boards In-Reply-To: <4F8B940B.7030700@st.com> References: <81b04bd4fe751633802e539d724facce80e600a4.1334207964.git.viresh.kumar@st.com> <4F8851E5.7050509@wwwdotorg.org> <4F8B940B.7030700@st.com> Message-ID: <4F8C5F68.7070105@wwwdotorg.org> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 04/15/2012 09:37 PM, Viresh Kumar wrote: > On 4/13/2012 9:48 PM, Stephen Warren wrote: ... >> Just a couple of minor comments below. ... > As you have spent a lot of time getting these reviewed, i would add your > Reviewed-by on all these patches. Hope that would be fine? Sure. Note that I explicitly didn't review the pin/group/function data, but concentrated more on the general framework of the driver, but I think that's enough to add my Reviewed-by. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Warren Subject: Re: [PATCH V3 4/4] SPEAr3xx: Add pinctrl support for boards Date: Mon, 16 Apr 2012 12:05:28 -0600 Message-ID: <4F8C5F68.7070105@wwwdotorg.org> References: <81b04bd4fe751633802e539d724facce80e600a4.1334207964.git.viresh.kumar@st.com> <4F8851E5.7050509@wwwdotorg.org> <4F8B940B.7030700@st.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <4F8B940B.7030700-qxv4g6HH51o@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org Sender: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org To: Viresh Kumar Cc: "devicetree-discuss-mnsaURCQ41sdnm+yROfE0A@public.gmane.org" , spear-devel , "viresh.linux-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org" , "linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org" List-Id: devicetree@vger.kernel.org On 04/15/2012 09:37 PM, Viresh Kumar wrote: > On 4/13/2012 9:48 PM, Stephen Warren wrote: ... >> Just a couple of minor comments below. ... > As you have spent a lot of time getting these reviewed, i would add your > Reviewed-by on all these patches. Hope that would be fine? Sure. Note that I explicitly didn't review the pin/group/function data, but concentrated more on the general framework of the driver, but I think that's enough to add my Reviewed-by.