All of lore.kernel.org
 help / color / mirror / Atom feed
From: John Stultz <john.stultz@linaro.org>
To: Mark Lord <kernel@teksavvy.com>
Cc: richard -rw- weinberger <richard.weinberger@gmail.com>,
	Linux Kernel <linux-kernel@vger.kernel.org>,
	rtc-linux@googlegroups.com,
	Alessandro Zummo <a.zummo@towertech.it>,
	Greg Kroah-Hartman <greg@kroah.com>,
	stable@vger.kernel.org,
	Rabin Vincent <rabin.vincent@stericsson.com>
Subject: Re: [REGRESSION] rtc/interface.c: kills suspend-to-ram
Date: Mon, 16 Apr 2012 12:45:47 -0700	[thread overview]
Message-ID: <4F8C76EB.20709@linaro.org> (raw)
In-Reply-To: <4F8C415C.80806@teksavvy.com>

On 04/16/2012 08:57 AM, Mark Lord wrote:
> On 12-04-16 11:49 AM, richard -rw- weinberger wrote:
>> On Mon, Apr 16, 2012 at 5:42 PM, Mark Lord<kernel@teksavvy.com>  wrote:
>>> On 12-04-16 10:23 AM, richard -rw- weinberger wrote:
>>>> On Mon, Apr 16, 2012 at 3:55 PM, Mark Lord<kernel@teksavvy.com>  wrote:
>>>>> On 12-04-16 12:36 AM, Mark Lord wrote:
>>>>>> Something recent has killed suspend-to-ram on a number of machines here.
>>>>>> The symptom is that they suspend, but immediately wake up and panic,
>>>>>> with just a black screen so no visible messages to go by.
>>>>>>
>>>>>> The patch below works around the issue -- making things work as they used to work.
>>>>>>
>>>>>> +++ linux/drivers/rtc/interface.c     2012-04-16 00:09:14.105387382 -0400
>>>>>> @@ -773,7 +773,7 @@
>>>>>>        if (!rtc->ops || !rtc->ops->alarm_irq_enable)
>>>>>>                return;
>>>>>>
>>>>>> -     rtc->ops->alarm_irq_enable(rtc->dev.parent, false);
>>>>>> +     //rtc->ops->alarm_irq_enable(rtc->dev.parent, false);  // Kills suspend on ZBOX HD-ID41U
>>>>>>   }
>>>
>>> How about the line above -- that's the commit that breaks things here.
>> Download Linus' GIT tree and use git blame. :-)
> Too steep a learning curve for a casual user.
> But google works:
>
> http://www.mail-archive.com/stable@vger.kernel.org/msg04391.html

Thanks for the report and sorry for the trouble.  I'm trying to 
reproduce this locally. Can you send me your .config?

thanks
-john


  reply	other threads:[~2012-04-16 20:56 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-16  4:36 [REGRESSION] rtc/interface.c: kills suspend-to-ram Mark Lord
2012-04-16 13:55 ` Mark Lord
2012-04-16 14:23   ` richard -rw- weinberger
2012-04-16 14:23     ` richard -rw- weinberger
2012-04-16 15:42     ` Mark Lord
2012-04-16 15:49       ` richard -rw- weinberger
2012-04-16 15:49         ` richard -rw- weinberger
2012-04-16 15:57         ` Mark Lord
2012-04-16 19:45           ` John Stultz [this message]
2012-04-16 21:43             ` John Stultz
2012-04-17  2:30               ` Mark Lord
2012-04-17  5:13                 ` John Stultz
2012-04-17 12:51                   ` Mark Lord
2012-04-17 20:11                   ` Mark Lord
2012-04-17 20:12                     ` Mark Lord
2012-04-17 23:02                     ` John Stultz
2012-04-18  1:29                       ` Mark Lord
2012-04-18 18:29                         ` John Stultz
2012-04-27 14:33                           ` Mark Lord
2012-04-27 19:22                             ` John Stultz
2012-04-16 19:44     ` John Stultz
2012-04-17  2:27       ` Mark Lord
2012-04-16 14:26   ` [rtc-linux] " Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F8C76EB.20709@linaro.org \
    --to=john.stultz@linaro.org \
    --cc=a.zummo@towertech.it \
    --cc=greg@kroah.com \
    --cc=kernel@teksavvy.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rabin.vincent@stericsson.com \
    --cc=richard.weinberger@gmail.com \
    --cc=rtc-linux@googlegroups.com \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.