Re: [PATCH 1/1] poky-tiny: fix eglibc configuration

[Darren Hart <dvhart@linux.intel.com>]

On 04/16/2012 03:23 PM, nitin.a.kamble@intel.com wrote:
> From: Nitin A Kamble <nitin.a.kamble@intel.com>
> 
> eglibc needs libc-posix-regexp-glibc & libc-libm-big enabled in it's
> configuration to avoid following eglibc build issue.
> 
> ...
> | In file included from xregex.c:634:0:
> | xregex.c: In function 'byte_regex_compile':
> | xregex.c:3395:8: error: too few arguments to function 'findidx'
> | ../locale/weight.h:23:1: note: declared here
> ...
> 
> This fixes bug [YOCTO #2295]
> 
> Signed-off-by: Nitin A Kamble <nitin.a.kamble@intel.com>
> ---
>  meta-yocto/conf/distro/poky-tiny.conf |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/meta-yocto/conf/distro/poky-tiny.conf b/meta-yocto/conf/distro/poky-tiny.conf
> index 58d64ec..626b2d0 100644
> --- a/meta-yocto/conf/distro/poky-tiny.conf
> +++ b/meta-yocto/conf/distro/poky-tiny.conf
> @@ -62,7 +62,7 @@ ASSUME_PROVIDED += "pkgconfig$"
>  
>  # Reconfigure eglibc for a smaller installation
>  # Comment out any of the lines below to disable them in the build
> -DISTRO_FEATURES_LIBC_TINY = "libc-libm libc-crypt"
> +DISTRO_FEATURES_LIBC_TINY = "libc-libm libc-libm-big libc-crypt"
>  # for gettext
>  DISTRO_FEATURES_LIBC_TINY += "libc-posix-clang-wchar"
>  # for m4
> @@ -71,7 +71,7 @@ DISTRO_FEATURES_LIBC_TINY += "libc-spawn libc-locale-code"
>  DISTRO_FEATURES_LIBC_TINY += "libc-ftraverse"
>  # Required for "who"
>  DISTRO_FEATURES_LIBC_MINIMAL = "libc-utmp libc-getlogin"
> -DISTRO_FEATURES_LIBC_REGEX = "libc-posix-regexp"
> +DISTRO_FEATURES_LIBC_REGEX = "libc-posix-regexp libc-posix-regexp-glibc"
>  DISTRO_FEATURES_LIBC_NET = "libc-inet libc-nis"
>  
>  DISTRO_FEATURES_LIBC = "${DISTRO_FEATURES_LIBC_TINY} \

I have a patch that makes it clear which features are added for the
toolchain. This will make it easier to reduce in the future as well.
I'll test with the libm-big added to that and report on size increase
and send that patch for inclusion.

Nitin, thank you for identifying the missing lib. I would prefer we not
merge this patch as is. It will only collide with my cleanup patch. I
might as well integrate it into the cleanup patch and send it out as
one. Will have it tested and sent out as soon as I can get a few builds
to complete.


-- 
Darren Hart
Intel Open Source Technology Center
Yocto Project - Linux Kernel