Re: [PATCH 3/4] ksysfs: export VMCSINFO via sysfs

[zhangyanfei <zhangyanfei@cn.fujitsu.com>]

于 2012年04月13日 07:00, Greg KH 写道:
> On Wed, Apr 11, 2012 at 09:57:34AM +0800, zhangyanfei wrote:
>> This patch creates sysfs file to export where VMCSINFO is allocated,
>> as below:
>>         $ cat /sys/kernel/vmcsinfo
>>         1cb88a0 2000
>> number on the left-hand side is the physical address of VMCSINFO,
>> while the one on the right-hand side is the max size of VMCSINFO.
> 
> Ick, why do you have 2 values in one sysfs file, that's not nice, or
> good.
> 
> What's wrong with 2 different files?
> 

The reason why I put the 2 values in one sysfs file is that there is a similar
file 'vmcoreinfo' in sysfs.
        # cat /sys/kernel/vmcoreinfo 
        1d75380 1000
Nothing wrong with two different files, I just wanted to export the vmcsinfo
with the interface that is the same as vmcoreinfo. So later in kexec-tools,
vmcsinfo note information will be handled in a very similar way as vmcoreinfo
note information.

> Also, any new sysfs file you add needs to also have a Documentation/ABI
> entry added as well.

Sorry for missing this. I will add it in next version of patch.

> 
> But we can't accept this as-is, sorry, please split it up into 2 files.
>
 
Thanks
Zhang Yanfei


_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec