From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from [222.73.24.84] (helo=song.cn.fujitsu.com) by merlin.infradead.org with esmtp (Exim 4.76 #1 (Red Hat Linux)) id 1SJxip-0000UJ-4f for kexec@lists.infradead.org; Tue, 17 Apr 2012 02:00:48 +0000 Message-ID: <4F8CCCEA.2090706@cn.fujitsu.com> Date: Tue, 17 Apr 2012 09:52:42 +0800 From: zhangyanfei MIME-Version: 1.0 Subject: Re: [PATCH 3/4] ksysfs: export VMCSINFO via sysfs References: <4F84E0DF.8040206@cn.fujitsu.com> <4F84E50E.2090008@cn.fujitsu.com> <20120412230058.GA23292@kroah.com> In-Reply-To: <20120412230058.GA23292@kroah.com> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: kexec-bounces@lists.infradead.org Errors-To: kexec-bounces+dwmw2=infradead.org@lists.infradead.org To: Greg KH Cc: dzickus@redhat.com, luto@mit.edu, kvm@vger.kernel.org, joerg.roedel@amd.com, mtosatti@redhat.com, kexec@lists.infradead.org, linux-kernel@vger.kernel.org, paul.gortmaker@windriver.com, ludwig.nussel@suse.de, avi@redhat.com, ebiederm@xmission.com 5LqOIDIwMTLlubQwNOaciDEz5pelIDA3OjAwLCBHcmVnIEtIIOWGmemBkzoKPiBPbiBXZWQsIEFw ciAxMSwgMjAxMiBhdCAwOTo1NzozNEFNICswODAwLCB6aGFuZ3lhbmZlaSB3cm90ZToKPj4gVGhp cyBwYXRjaCBjcmVhdGVzIHN5c2ZzIGZpbGUgdG8gZXhwb3J0IHdoZXJlIFZNQ1NJTkZPIGlzIGFs bG9jYXRlZCwKPj4gYXMgYmVsb3c6Cj4+ICAgICAgICAgJCBjYXQgL3N5cy9rZXJuZWwvdm1jc2lu Zm8KPj4gICAgICAgICAxY2I4OGEwIDIwMDAKPj4gbnVtYmVyIG9uIHRoZSBsZWZ0LWhhbmQgc2lk ZSBpcyB0aGUgcGh5c2ljYWwgYWRkcmVzcyBvZiBWTUNTSU5GTywKPj4gd2hpbGUgdGhlIG9uZSBv biB0aGUgcmlnaHQtaGFuZCBzaWRlIGlzIHRoZSBtYXggc2l6ZSBvZiBWTUNTSU5GTy4KPiAKPiBJ Y2ssIHdoeSBkbyB5b3UgaGF2ZSAyIHZhbHVlcyBpbiBvbmUgc3lzZnMgZmlsZSwgdGhhdCdzIG5v dCBuaWNlLCBvcgo+IGdvb2QuCj4gCj4gV2hhdCdzIHdyb25nIHdpdGggMiBkaWZmZXJlbnQgZmls ZXM/Cj4gCgpUaGUgcmVhc29uIHdoeSBJIHB1dCB0aGUgMiB2YWx1ZXMgaW4gb25lIHN5c2ZzIGZp bGUgaXMgdGhhdCB0aGVyZSBpcyBhIHNpbWlsYXIKZmlsZSAndm1jb3JlaW5mbycgaW4gc3lzZnMu CiAgICAgICAgIyBjYXQgL3N5cy9rZXJuZWwvdm1jb3JlaW5mbyAKICAgICAgICAxZDc1MzgwIDEw MDAKTm90aGluZyB3cm9uZyB3aXRoIHR3byBkaWZmZXJlbnQgZmlsZXMsIEkganVzdCB3YW50ZWQg dG8gZXhwb3J0IHRoZSB2bWNzaW5mbwp3aXRoIHRoZSBpbnRlcmZhY2UgdGhhdCBpcyB0aGUgc2Ft ZSBhcyB2bWNvcmVpbmZvLiBTbyBsYXRlciBpbiBrZXhlYy10b29scywKdm1jc2luZm8gbm90ZSBp bmZvcm1hdGlvbiB3aWxsIGJlIGhhbmRsZWQgaW4gYSB2ZXJ5IHNpbWlsYXIgd2F5IGFzIHZtY29y ZWluZm8Kbm90ZSBpbmZvcm1hdGlvbi4KCj4gQWxzbywgYW55IG5ldyBzeXNmcyBmaWxlIHlvdSBh ZGQgbmVlZHMgdG8gYWxzbyBoYXZlIGEgRG9jdW1lbnRhdGlvbi9BQkkKPiBlbnRyeSBhZGRlZCBh cyB3ZWxsLgoKU29ycnkgZm9yIG1pc3NpbmcgdGhpcy4gSSB3aWxsIGFkZCBpdCBpbiBuZXh0IHZl cnNpb24gb2YgcGF0Y2guCgo+IAo+IEJ1dCB3ZSBjYW4ndCBhY2NlcHQgdGhpcyBhcy1pcywgc29y cnksIHBsZWFzZSBzcGxpdCBpdCB1cCBpbnRvIDIgZmlsZXMuCj4KIApUaGFua3MKWmhhbmcgWWFu ZmVpCgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18Ka2V4 ZWMgbWFpbGluZyBsaXN0CmtleGVjQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmlu ZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9rZXhlYwo= From mboxrd@z Thu Jan 1 00:00:00 1970 From: zhangyanfei Subject: Re: [PATCH 3/4] ksysfs: export VMCSINFO via sysfs Date: Tue, 17 Apr 2012 09:52:42 +0800 Message-ID: <4F8CCCEA.2090706@cn.fujitsu.com> References: <4F84E0DF.8040206@cn.fujitsu.com> <4F84E50E.2090008@cn.fujitsu.com> <20120412230058.GA23292@kroah.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: avi@redhat.com, mtosatti@redhat.com, ebiederm@xmission.com, luto@mit.edu, joerg.roedel@amd.com, dzickus@redhat.com, paul.gortmaker@windriver.com, ludwig.nussel@suse.de, linux-kernel@vger.kernel.org, kvm@vger.kernel.org, kexec@lists.infradead.org To: Greg KH Return-path: Received: from cn.fujitsu.com ([222.73.24.84]:2630 "EHLO song.cn.fujitsu.com" rhost-flags-OK-FAIL-OK-OK) by vger.kernel.org with ESMTP id S1750869Ab2DQCAn convert rfc822-to-8bit (ORCPT ); Mon, 16 Apr 2012 22:00:43 -0400 In-Reply-To: <20120412230058.GA23292@kroah.com> Sender: kvm-owner@vger.kernel.org List-ID: =E4=BA=8E 2012=E5=B9=B404=E6=9C=8813=E6=97=A5 07:00, Greg KH =E5=86=99=E9= =81=93: > On Wed, Apr 11, 2012 at 09:57:34AM +0800, zhangyanfei wrote: >> This patch creates sysfs file to export where VMCSINFO is allocated, >> as below: >> $ cat /sys/kernel/vmcsinfo >> 1cb88a0 2000 >> number on the left-hand side is the physical address of VMCSINFO, >> while the one on the right-hand side is the max size of VMCSINFO. >=20 > Ick, why do you have 2 values in one sysfs file, that's not nice, or > good. >=20 > What's wrong with 2 different files? >=20 The reason why I put the 2 values in one sysfs file is that there is a = similar file 'vmcoreinfo' in sysfs. # cat /sys/kernel/vmcoreinfo=20 1d75380 1000 Nothing wrong with two different files, I just wanted to export the vmc= sinfo with the interface that is the same as vmcoreinfo. So later in kexec-to= ols, vmcsinfo note information will be handled in a very similar way as vmco= reinfo note information. > Also, any new sysfs file you add needs to also have a Documentation/A= BI > entry added as well. Sorry for missing this. I will add it in next version of patch. >=20 > But we can't accept this as-is, sorry, please split it up into 2 file= s. > =20 Thanks Zhang Yanfei