From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1SKRRg-0007FP-3g for mharc-grub-devel@gnu.org; Wed, 18 Apr 2012 05:45:04 -0400 Received: from eggs.gnu.org ([208.118.235.92]:45420) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SKRRZ-00070k-CG for grub-devel@gnu.org; Wed, 18 Apr 2012 05:45:01 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SKRRT-0005G5-4l for grub-devel@gnu.org; Wed, 18 Apr 2012 05:44:56 -0400 Received: from mail-ey0-f169.google.com ([209.85.215.169]:56101) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SKRRS-0005Fs-S2 for grub-devel@gnu.org; Wed, 18 Apr 2012 05:44:51 -0400 Received: by eaal1 with SMTP id l1so1915921eaa.0 for ; Wed, 18 Apr 2012 02:44:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:user-agent:mime-version:to:subject:references :in-reply-to:x-enigmail-version:content-type; bh=CwI1XTr8JysFCH7cT43b1CusgHjp6J6Jhr92OK9drTY=; b=nHuR1AR6ZgzpFjYBo9pLBBf043j0fzrUF8qDBVn1WVZ9BslMnpvZERtUZkZzGQtvTU NuKC0mz1qDsh0BG5sxmzfXgibgOZjfiKtGvsx3n6dlqpHU+AKHcbM2bsvWya9BAP/5Ko FkWH5p/LBG3kK/PVkm5HLXyvkKfkcRozm//d+Sew0ROWST/+dSoQMQwNf3oD6aEeMumF 6kvdUhMzMIMva4p33sQ4p5l4n2Oc3NOFUhLYxnOck3lbjqD1iRD7nojm4A4WsK08jvL+ cCuBa7Z6xsQUUCiJXPEGKmnHBM/tgMrTBK3v4YwwPrZ5BU8lpqEpuzyvhK2y7MhU07cG QyjQ== Received: by 10.14.29.76 with SMTP id h52mr207595eea.77.1334742287809; Wed, 18 Apr 2012 02:44:47 -0700 (PDT) Received: from fedora.x201.phnet (vpn-global-225-dhcp.ethz.ch. [129.132.211.225]) by mx.google.com with ESMTPS id m42sm115434481eef.0.2012.04.18.02.44.45 (version=TLSv1/SSLv3 cipher=OTHER); Wed, 18 Apr 2012 02:44:46 -0700 (PDT) Message-ID: <4F8E8836.7020808@gmail.com> Date: Wed, 18 Apr 2012 11:24:06 +0200 From: =?UTF-8?B?VmxhZGltaXIgJ8+GLWNvZGVyL3BoY29kZXInIFNlcmJpbmVua28=?= User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:11.0) Gecko/20120329 Thunderbird/11.0.1 MIME-Version: 1.0 To: grub-devel@gnu.org Subject: Re: Improve support for genkernel in 10_linux References: <4F80B7AE.9000607@gentoo.org> <4F84F2D4.9030305@gentoo.org> <4F857384.10907@gmail.com> <4F8A30A0.7060401@gentoo.org> In-Reply-To: <4F8A30A0.7060401@gentoo.org> X-Enigmail-Version: 1.4 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="------------enig75B63FC6B98EC0E2A2A7A6E5" X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 209.85.215.169 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 18 Apr 2012 09:45:02 -0000 This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig75B63FC6B98EC0E2A2A7A6E5 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 15.04.2012 04:21, Mike Gilbert wrote: > On 04/11/2012 11:52 AM, Mike Gilbert wrote: >> 2012/4/11 Vladimir '=CF=86-coder/phcoder' Serbinenko : >>> On 11.04.2012 04:56, Mike Gilbert wrote: >>>> On 04/07/2012 05:54 PM, Mike Gilbert wrote: >>>>> Secondly, genkernel looks for the "real_root" kernel command line o= ption >>>>> to determine the root filesystem. This is a holdover from the days = when >>>>> we used true initrd images and we needed to use root=3D/dev/ram0. >>>>> >>>> It was brought to my attention that genkernel's initramfs code will = in >>>> fact utilize "root" if "real_root" is unset. This part of my previou= s >>>> patch is therefore pointless. >>>> >>>> I have attached a revised patch containing only the changes necessar= y to >>>> detect a genkernel initramfs image. >>>> >>> pushd/popd isn't POSIX so we can't use it in our scripts. Also I don'= t >>> feel like glob expansion is the right thing to use here. Why not infe= r >>> the architecture from uname ? >> That should also work. Here's the logic that genkernel uses to populat= e ARCH: >> >> ARCH=3D`uname -m` >> case "${ARCH}" in >> i?86) >> ARCH=3D"x86" >> ;; >> mips|mips64) >> ARCH=3D"mips" >> ;; >> arm*) >> ARCH=3Darm >> ;; >> *) >> ;; >> esac >> >> I'm thinking it would be a good idea to rename ARCH to something like >> GENKERNEL_ARCH. We should also let the user override this in >> /etc/default/grub. >> >> Does that sound ok? > I have modified my patch to implement what I describe above. > What is the reason to make it configurable? There shouldn't be any need to configure something that is autodetected --=20 Regards Vladimir '=CF=86-coder/phcoder' Serbinenko --------------enig75B63FC6B98EC0E2A2A7A6E5 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iF4EAREKAAYFAk+OiD0ACgkQNak7dOguQgmRywD/elGi6A4d59XZL5mw6tZwHAsj smEBDLHAlB15nfFN3iAA/R7zxBKo4VfLB/sZCGRFHWQm4CJNfXtB4OThunVjYnUW =NzUJ -----END PGP SIGNATURE----- --------------enig75B63FC6B98EC0E2A2A7A6E5--