From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joonyoung Shim Subject: Re: [RFC PATCH] drm: Add plane event Date: Wed, 18 Apr 2012 19:11:45 +0900 Message-ID: <4F8E9361.3080004@samsung.com> References: <1334723519-32141-1-git-send-email-jy0922.shim@samsung.com> <20120418084634.GC5315@phenom.ffwll.local> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: Received: from mailout1.samsung.com (mailout1.samsung.com [203.254.224.24]) by gabe.freedesktop.org (Postfix) with ESMTP id 670E79E74C for ; Wed, 18 Apr 2012 03:11:50 -0700 (PDT) Received: from epcpsbgm2.samsung.com (mailout1.samsung.com [203.254.224.24]) by mailout1.samsung.com (Oracle Communications Messaging Server 7u4-24.01(7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0M2O009EF6Z5HBN0@mailout1.samsung.com> for dri-devel@lists.freedesktop.org; Wed, 18 Apr 2012 19:11:48 +0900 (KST) Received: from [165.213.219.123] by mmp1.samsung.com (Oracle Communications Messaging Server 7u4-24.01(7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0M2O00ANX6ZL7J30@mmp1.samsung.com> for dri-devel@lists.freedesktop.org; Wed, 18 Apr 2012 19:11:45 +0900 (KST) In-reply-to: <20120418084634.GC5315@phenom.ffwll.local> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org To: Daniel Vetter Cc: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org On 04/18/2012 05:46 PM, Daniel Vetter wrote: > On Wed, Apr 18, 2012 at 01:31:59PM +0900, Joonyoung Shim wrote: >> DRM_MODE_PLANE_EVENT is similar to DRM_MODE_PAGE_FLIP_EVENT but it is >> for a plane. The setplane ioctl (DRM_IOCTL_MODE_SETPLANE) needs to >> provide the event such as DRM_MODE_PAGE_FLIP_EVENT. The setplane ioctl >> can change the framebuffer of plane but user can't know completion of >> changing the framebuffer of plane via event. If DRM_MODE_PLANE_EVENT is >> added, we can also do pageflip of a plane. >> >> Signed-off-by: Joonyoung Shim >> Signed-off-by: Kyungmin Park > If I understand the current kms api correctly, set_plane is akin to > set_base and should not generate an asynchronous flip completion event. To > do that we need a new pageflip ioctl which changes a complete set of fb + > planes + any crtc attributes that might be in an atomic fashion. At which > point we can just reuse the existing page flip event mechanism. It seems better way to add new pageflip ioctl for plane. I will try it. Thanks for review.