All of lore.kernel.org
 help / color / mirror / Atom feed
From: Avi Kivity <avi@redhat.com>
To: Nadav Har'El <nyh@math.technion.ac.il>
Cc: kexec@lists.infradead.org, kvm@vger.kernel.org,
	Anthony Liguori <anthony@codemonkey.ws>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/4] Export offsets of VMCS fields as note information for kdump
Date: Wed, 18 Apr 2012 17:06:07 +0300	[thread overview]
Message-ID: <4F8ECA4F.7070305@redhat.com> (raw)
In-Reply-To: <20120418134743.GA25786@fermat.math.technion.ac.il>

On 04/18/2012 04:47 PM, Nadav Har'El wrote:
> On Wed, Apr 18, 2012, Avi Kivity wrote about "Re: [PATCH 0/4] Export offsets of VMCS fields as note information for kdump":
> > Right; they're also not required to be in memory at all - the processor
> > can cache them, even for VMCSs that are not active at this time. 
> > Running VMXOFF at panic time can fix that, but you have to broadcast it
> > to all processors, probably using NMI...
>
> I believe that a VMCLEAR ensures that the VMCS is written back to
> memory. KVM uses this fact when migrating a VMCS between two separate
> physical CPUs - it runs VMCLEAR on the old CPU, to write the VMCS to
> memory, and then VMPTRLD on the new CPU.
>
> So you don't need to VMXOFF, but do need to VMCLEAR. But there's still
> the complication that you mention - you need to do the VMCLEAR on the right
> processor...

VMCLEAR only clears one VMCS; several may be cached by a processor at
one time.  Presumably VMXOFF flushes everything.

-- 
error compiling committee.c: too many arguments to function


_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec

WARNING: multiple messages have this Message-ID (diff)
From: Avi Kivity <avi-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
To: "Nadav Har'El" <nyh-TS7m/3hpY0sOpacJJkBjfT4kX+cae0hd@public.gmane.org>
Cc: kexec-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	kvm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	Anthony Liguori <anthony-rdkfGonbjUSkNkDKm+mE6A@public.gmane.org>,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH 0/4] Export offsets of VMCS fields as note information for kdump
Date: Wed, 18 Apr 2012 17:06:07 +0300	[thread overview]
Message-ID: <4F8ECA4F.7070305@redhat.com> (raw)
In-Reply-To: <20120418134743.GA25786-QeE623+hzFJ/hwrKWqB9+zWi1Rwp9Q0N+oGz7xIJsNs@public.gmane.org>

On 04/18/2012 04:47 PM, Nadav Har'El wrote:
> On Wed, Apr 18, 2012, Avi Kivity wrote about "Re: [PATCH 0/4] Export offsets of VMCS fields as note information for kdump":
> > Right; they're also not required to be in memory at all - the processor
> > can cache them, even for VMCSs that are not active at this time. 
> > Running VMXOFF at panic time can fix that, but you have to broadcast it
> > to all processors, probably using NMI...
>
> I believe that a VMCLEAR ensures that the VMCS is written back to
> memory. KVM uses this fact when migrating a VMCS between two separate
> physical CPUs - it runs VMCLEAR on the old CPU, to write the VMCS to
> memory, and then VMPTRLD on the new CPU.
>
> So you don't need to VMXOFF, but do need to VMCLEAR. But there's still
> the complication that you mention - you need to do the VMCLEAR on the right
> processor...

VMCLEAR only clears one VMCS; several may be cached by a processor at
one time.  Presumably VMXOFF flushes everything.

-- 
error compiling committee.c: too many arguments to function

WARNING: multiple messages have this Message-ID (diff)
From: Avi Kivity <avi@redhat.com>
To: "Nadav Har'El" <nyh@math.technion.ac.il>
Cc: Anthony Liguori <anthony@codemonkey.ws>,
	kvm@vger.kernel.org, kexec@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/4] Export offsets of VMCS fields as note information for kdump
Date: Wed, 18 Apr 2012 17:06:07 +0300	[thread overview]
Message-ID: <4F8ECA4F.7070305@redhat.com> (raw)
In-Reply-To: <20120418134743.GA25786@fermat.math.technion.ac.il>

On 04/18/2012 04:47 PM, Nadav Har'El wrote:
> On Wed, Apr 18, 2012, Avi Kivity wrote about "Re: [PATCH 0/4] Export offsets of VMCS fields as note information for kdump":
> > Right; they're also not required to be in memory at all - the processor
> > can cache them, even for VMCSs that are not active at this time. 
> > Running VMXOFF at panic time can fix that, but you have to broadcast it
> > to all processors, probably using NMI...
>
> I believe that a VMCLEAR ensures that the VMCS is written back to
> memory. KVM uses this fact when migrating a VMCS between two separate
> physical CPUs - it runs VMCLEAR on the old CPU, to write the VMCS to
> memory, and then VMPTRLD on the new CPU.
>
> So you don't need to VMXOFF, but do need to VMCLEAR. But there's still
> the complication that you mention - you need to do the VMCLEAR on the right
> processor...

VMCLEAR only clears one VMCS; several may be cached by a processor at
one time.  Presumably VMXOFF flushes everything.

-- 
error compiling committee.c: too many arguments to function


  reply	other threads:[~2012-04-18 14:06 UTC|newest]

Thread overview: 109+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-11  1:39 [PATCH 0/4] Export offsets of VMCS fields as note information for kdump zhangyanfei
2012-04-11  1:39 ` zhangyanfei
2012-04-11  1:49 ` [PATCH 1/4] x86: Add helper variables and functions to hold VMCSINFO zhangyanfei
2012-04-11  1:49   ` zhangyanfei
2012-04-11  1:50 ` [PATCH 2/4] KVM: VMX: Add functions to fill VMCSINFO zhangyanfei
2012-04-11  1:50   ` zhangyanfei
2012-04-11  8:48   ` Avi Kivity
2012-04-11  8:48     ` Avi Kivity
2012-04-11  8:48     ` Avi Kivity
2012-04-11 10:34     ` zhangyanfei
2012-04-11 10:34       ` zhangyanfei
2012-04-11 10:34       ` zhangyanfei
2012-04-11 11:41       ` Avi Kivity
2012-04-11 11:41         ` Avi Kivity
2012-04-11 11:41         ` Avi Kivity
2012-04-11  1:57 ` [PATCH 3/4] ksysfs: export VMCSINFO via sysfs zhangyanfei
2012-04-11  1:57   ` zhangyanfei
2012-04-11  1:57   ` zhangyanfei
2012-04-12 23:00   ` Greg KH
2012-04-12 23:00     ` Greg KH
2012-04-12 23:00     ` Greg KH
2012-04-17  1:52     ` zhangyanfei
2012-04-17  1:52       ` zhangyanfei
2012-04-17  2:30       ` Greg KH
2012-04-17  2:30         ` Greg KH
2012-04-11  1:58 ` [PATCH 4/4] kexec: Add crash_save_vmcsinfo to update VMCSINFO zhangyanfei
2012-04-11  1:58   ` zhangyanfei
2012-04-11  1:58   ` zhangyanfei
2012-04-11  8:56 ` [PATCH 0/4] Export offsets of VMCS fields as note information for kdump Avi Kivity
2012-04-11  8:56   ` Avi Kivity
2012-04-11 10:12   ` zhangyanfei
2012-04-11 10:12     ` zhangyanfei
2012-04-11 10:12     ` zhangyanfei
2012-04-11 11:15     ` Avi Kivity
2012-04-11 11:15       ` Avi Kivity
2012-04-11 10:21 ` Joerg Roedel
2012-04-11 10:21   ` Joerg Roedel
2012-04-11 10:21   ` Joerg Roedel
2012-04-11 10:49   ` Avi Kivity
2012-04-11 10:49     ` Avi Kivity
2012-04-11 10:49     ` Avi Kivity
2012-04-11 10:59   ` zhangyanfei
2012-04-11 10:59     ` zhangyanfei
2012-04-11 10:59     ` zhangyanfei
2012-04-17  7:44 ` Avi Kivity
2012-04-17  7:44   ` Avi Kivity
2012-04-17  7:44   ` Avi Kivity
2012-04-17 10:51   ` zhangyanfei
2012-04-17 10:51     ` zhangyanfei
2012-04-17 10:51     ` zhangyanfei
2012-04-17 10:59     ` Avi Kivity
2012-04-17 10:59       ` Avi Kivity
2012-04-17 10:59       ` Avi Kivity
2012-04-17 11:25       ` Wen Congyang
2012-04-17 11:25         ` Wen Congyang
2012-04-17 11:25         ` Wen Congyang
2012-04-17 13:04         ` Avi Kivity
2012-04-17 13:04           ` Avi Kivity
2012-04-17 13:04           ` Avi Kivity
2012-04-18  7:30       ` zhangyanfei
2012-04-18  7:30         ` zhangyanfei
2012-04-18  7:30         ` zhangyanfei
2012-04-18  8:24         ` Avi Kivity
2012-04-18  8:24           ` Avi Kivity
2012-04-18  8:24           ` Avi Kivity
2012-04-18  9:49           ` zhangyanfei
2012-04-18  9:49             ` zhangyanfei
2012-04-18  9:49             ` zhangyanfei
2012-04-18 11:56             ` Avi Kivity
2012-04-18 11:56               ` Avi Kivity
2012-04-18 11:56               ` Avi Kivity
2012-04-19 10:36               ` HATAYAMA Daisuke
2012-04-19 10:36                 ` HATAYAMA Daisuke
2012-04-19 10:36                 ` HATAYAMA Daisuke
2012-04-19 10:42                 ` Avi Kivity
2012-04-19 10:42                   ` Avi Kivity
2012-04-19 10:42                   ` Avi Kivity
2012-04-19 11:27                   ` HATAYAMA Daisuke
2012-04-19 11:27                     ` HATAYAMA Daisuke
2012-04-19 11:27                     ` HATAYAMA Daisuke
2012-04-19 11:31                     ` Avi Kivity
2012-04-19 11:31                       ` Avi Kivity
2012-04-19 11:31                       ` Avi Kivity
2012-04-19 12:01                       ` HATAYAMA Daisuke
2012-04-19 12:01                         ` HATAYAMA Daisuke
2012-04-19 12:01                         ` HATAYAMA Daisuke
2012-04-19 12:08                         ` Avi Kivity
2012-04-19 12:08                           ` Avi Kivity
2012-04-19 12:08                           ` Avi Kivity
2012-04-20 10:11                           ` HATAYAMA Daisuke
2012-04-20 10:11                             ` HATAYAMA Daisuke
2012-04-20 10:11                             ` HATAYAMA Daisuke
2012-04-22  9:58                             ` Avi Kivity
2012-04-22  9:58                               ` Avi Kivity
2012-04-22 10:33                               ` Gleb Natapov
2012-04-22 10:33                                 ` Gleb Natapov
2012-04-22 10:33                                 ` Gleb Natapov
2012-04-22 10:57                                 ` Avi Kivity
2012-04-22 10:57                                   ` Avi Kivity
2012-04-22 10:57                                   ` Avi Kivity
2012-04-17 16:49   ` Anthony Liguori
2012-04-18 12:13     ` Avi Kivity
2012-04-18 12:13       ` Avi Kivity
2012-04-18 12:13       ` Avi Kivity
2012-04-18 13:47       ` Nadav Har'El
2012-04-18 13:47         ` Nadav Har'El
2012-04-18 14:06         ` Avi Kivity [this message]
2012-04-18 14:06           ` Avi Kivity
2012-04-18 14:06           ` Avi Kivity

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F8ECA4F.7070305@redhat.com \
    --to=avi@redhat.com \
    --cc=anthony@codemonkey.ws \
    --cc=kexec@lists.infradead.org \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nyh@math.technion.ac.il \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.