From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1SKWcZ-0002BH-6t for mharc-grub-devel@gnu.org; Wed, 18 Apr 2012 11:16:39 -0400 Received: from eggs.gnu.org ([208.118.235.92]:55921) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SKWcT-00029m-CS for grub-devel@gnu.org; Wed, 18 Apr 2012 11:16:37 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SKWcJ-0007UX-9V for grub-devel@gnu.org; Wed, 18 Apr 2012 11:16:32 -0400 Received: from mail-ey0-f169.google.com ([209.85.215.169]:46471) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SKWcI-0007U4-W2 for grub-devel@gnu.org; Wed, 18 Apr 2012 11:16:23 -0400 Received: by eaal1 with SMTP id l1so2023912eaa.0 for ; Wed, 18 Apr 2012 08:16:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:user-agent:mime-version:to:subject:references :in-reply-to:x-enigmail-version:content-type; bh=xp3grY6sfyIGoLl7tqh+2NwEh42b5Xq0WUWMBpV9uFk=; b=mKBzjB96FCzjKTf0Fj+g8T3m6EFm//f686fHnd6iqrZBLtclXbNSEsQf/9oRaN0aA0 d1/Y0JQionuiRgNjEUcaYS0HdrmZJ7WYJ9HPoEbNvd5+9HUwFYwQEpFE3QB8SYzhWnPu c224GWNB35uJxp0YtiV7rAyodTRSG2MRhdcYcQWC+UiCmumFQPntas+Cv5FNf2x/hQxY or+hbd1sUtI3fmyjWO5Cd747BPkcV07+TLtTtDE9HS7FMcHf7xSBrUbRmZOrvt1llaWZ Clc+8M1ZGzAsxaBhmIoNI/DQis285dTe99L9y9IfH0ib9PQlEa7tQg3HdvOYf/HIg3h3 8qCQ== Received: by 10.14.188.141 with SMTP id a13mr435408een.56.1334762180930; Wed, 18 Apr 2012 08:16:20 -0700 (PDT) Received: from debian.x201.phnet (95-232.197-178.cust.bluewin.ch. [178.197.232.95]) by mx.google.com with ESMTPS id d54sm119136245eei.9.2012.04.18.08.16.18 (version=TLSv1/SSLv3 cipher=OTHER); Wed, 18 Apr 2012 08:16:19 -0700 (PDT) Message-ID: <4F8EDAC1.7040402@gmail.com> Date: Wed, 18 Apr 2012 17:16:17 +0200 From: =?UTF-8?B?VmxhZGltaXIgJ8+GLWNvZGVyL3BoY29kZXInIFNlcmJpbmVua28=?= User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:10.0.3) Gecko/20120329 Icedove/10.0.3 MIME-Version: 1.0 To: grub-devel@gnu.org Subject: Re: Improve support for genkernel in 10_linux References: <4F80B7AE.9000607@gentoo.org> <4F84F2D4.9030305@gentoo.org> <4F857384.10907@gmail.com> <4F8A30A0.7060401@gentoo.org> <4F8E8836.7020808@gmail.com> In-Reply-To: X-Enigmail-Version: 1.4 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="------------enig841B4B9E67140CB58165F7F8" X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 209.85.215.169 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 18 Apr 2012 15:16:38 -0000 This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig841B4B9E67140CB58165F7F8 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 18.04.2012 17:06, Mike Gilbert wrote: > 2012/4/18 Vladimir '=CF=86-coder/phcoder' Serbinenko : >> On 15.04.2012 04:21, Mike Gilbert wrote: >>> On 04/11/2012 11:52 AM, Mike Gilbert wrote: >>>> 2012/4/11 Vladimir '=CF=86-coder/phcoder' Serbinenko : >>>>> On 11.04.2012 04:56, Mike Gilbert wrote: >>>>>> On 04/07/2012 05:54 PM, Mike Gilbert wrote: >>>>>>> Secondly, genkernel looks for the "real_root" kernel command line= option >>>>>>> to determine the root filesystem. This is a holdover from the day= s when >>>>>>> we used true initrd images and we needed to use root=3D/dev/ram0.= >>>>>>> >>>>>> It was brought to my attention that genkernel's initramfs code wil= l in >>>>>> fact utilize "root" if "real_root" is unset. This part of my previ= ous >>>>>> patch is therefore pointless. >>>>>> >>>>>> I have attached a revised patch containing only the changes necess= ary to >>>>>> detect a genkernel initramfs image. >>>>>> >>>>> pushd/popd isn't POSIX so we can't use it in our scripts. Also I do= n't >>>>> feel like glob expansion is the right thing to use here. Why not in= fer >>>>> the architecture from uname ? >>>> That should also work. Here's the logic that genkernel uses to popul= ate ARCH: >>>> >>>> ARCH=3D`uname -m` >>>> case "${ARCH}" in >>>> i?86) >>>> ARCH=3D"x86" >>>> ;; >>>> mips|mips64) >>>> ARCH=3D"mips" >>>> ;; >>>> arm*) >>>> ARCH=3Darm >>>> ;; >>>> *) >>>> ;; >>>> esac >>>> >>>> I'm thinking it would be a good idea to rename ARCH to something lik= e >>>> GENKERNEL_ARCH. We should also let the user override this in >>>> /etc/default/grub. >>>> >>>> Does that sound ok? >>> I have modified my patch to implement what I describe above. >>> >> What is the reason to make it configurable? There shouldn't be any nee= d >> to configure something that is autodetected >> > genkernel allows the user to cross-compile their kernel and/or > initramfs, in which case uname -m would not provide the correct value. > > I don't have a clear picture in my mind of how that would work with > grub, but I figure it would be better to err on the side of > flexibility. grub-mkconfig doesn't support cross-configuration and arch name is just one of the problems. Unless we have a designed system for this case it's useless to add stray bits which don't work anyway. --=20 Regards Vladimir '=CF=86-coder/phcoder' Serbinenko --------------enig841B4B9E67140CB58165F7F8 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iF4EAREKAAYFAk+O2sEACgkQNak7dOguQgkW/wD+Ow2D0so9JZsixdpZvIz7fbDY sSjnquBdJcPqvzTux1gA/3l4koTVaV2Ehf+3fnx7K4/fqbHxZgq20F9gERU0F/6z =rXWR -----END PGP SIGNATURE----- --------------enig841B4B9E67140CB58165F7F8--