From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753922Ab2DRSKk (ORCPT ); Wed, 18 Apr 2012 14:10:40 -0400 Received: from terminus.zytor.com ([198.137.202.10]:40857 "EHLO mail.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752102Ab2DRSKi (ORCPT ); Wed, 18 Apr 2012 14:10:38 -0400 Message-ID: <4F8F0385.5090901@zytor.com> Date: Wed, 18 Apr 2012 11:10:13 -0700 From: "H. Peter Anvin" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:11.0) Gecko/20120329 Thunderbird/11.0.1 MIME-Version: 1.0 To: "H.J. Lu" CC: mingo@redhat.com, linux-kernel@vger.kernel.org, tglx@linutronix.de, linux-tip-commits@vger.kernel.org Subject: Re: [tip:x86/x32] x32: Fix alignment fail in struct compat_siginfo References: <1329696488-16970-1-git-send-email-hpa@zytor.com> <4F8EFE4D.2040201@zytor.com> In-Reply-To: X-Enigmail-Version: 1.4 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 04/18/2012 11:01 AM, H.J. Lu wrote: > On Wed, Apr 18, 2012 at 10:47 AM, H. Peter Anvin wrote: >> On 04/18/2012 10:38 AM, H.J. Lu wrote: >>> >>> It doesn't match struct siginfo in include/asm-generic/siginfo.h for >>> x32. >>> >> >> What is missing (from either)? >> > > include/asm-generic/siginfo.h has > > /* SIGCHLD */ > struct { > __kernel_pid_t _pid; /* which child */ > __ARCH_SI_UID_T _uid; /* sender's uid */ > int _status; /* exit code */ > __kernel_clock_t _utime; > __kernel_clock_t _stime; > } _sigchld; > > > Although x32 __kernel_clock_t is s64 with 64bit alignment, in > _sigchld, it must be compat_s64 with 32bit alignment. > What would you suggest? Change __kernel_clock_t? It would somewhat stink to have to muck with things here. The problem here of course is that this is a phony misalignment... -hpa