From: Stephen Warren <swarren@wwwdotorg.org>
To: Wolfram Sang <w.sang@pengutronix.de>
Cc: Alok Chauhan <alokc@nvidia.com>,
khali@linux-fr.org, ben-linux@fluff.org, swarren@nvidia.com,
olof@lixom.net, bones@secretlab.ca, omaplinuxkernel@gmail.com,
ccross@android.com, ldewangan@nvidia.com,
linux-tegra@vger.kernel.org, linux-i2c@vger.kernel.org,
dgreid@chromium.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] i2c: tegra: Add delay before reset the controller
Date: Wed, 18 Apr 2012 14:02:05 -0600 [thread overview]
Message-ID: <4F8F1DBD.8000009@wwwdotorg.org> (raw)
In-Reply-To: <20120418142758.GE19220@pengutronix.de>
On 04/18/2012 08:27 AM, Wolfram Sang wrote:
> On Mon, Apr 02, 2012 at 11:23:02AM +0530, Alok Chauhan wrote:
>> NACK interrupt generated before I2C controller generates
>> the STOP condition on bus. In Software, because of this
>> reset of controller is happening before I2C controller could
>> complete STOP condition. So wait for some time before resetting
>> the controller so that STOP condition has delivered properly on bus.
>>
>> Added delay of 2 clock period before reset the
>> controller in case of NACK error.
>>
>> Signed-off-by: Alok Chauhan <alokc@nvidia.com>
>
> Applied with Stephen's ACK and slightly reworded comment and commit msg.
>
> Wondering a bit that you want it for 3.5, not for 3.4. Looks like a
> bugfix to me.
Yes, applying this to 3.4 would make sense. When I said "for 3.5"
earlier, I meant I'd like it to at least get into 3.5 not later.
Thanks.
next prev parent reply other threads:[~2012-04-18 20:02 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-02 5:53 [PATCH v2] i2c: tegra: Add delay before reset the controller Alok Chauhan
2012-04-02 5:53 ` Alok Chauhan
[not found] ` <1333345982-16595-1-git-send-email-alokc-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2012-04-02 5:59 ` Alok Chauhan
2012-04-02 5:59 ` Alok Chauhan
[not found] ` <7A0BFCFE3DA5CD47B0FB7984326F201A136BDCC35E-kdsAE/FnitNDw2glCA4ptUEOCMrvLtNR@public.gmane.org>
2012-04-02 10:19 ` Shubhrajyoti Datta
2012-04-02 10:19 ` Shubhrajyoti Datta
[not found] ` <CAM=Q2cuN+qAjDsBNp5Sq_Xs9KGcOQJ+PwjSVW-F0QczxMpWZRQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-04-02 12:06 ` Alok Chauhan
2012-04-02 12:06 ` Alok Chauhan
2012-04-02 19:58 ` Stephen Warren
2012-04-02 19:58 ` Stephen Warren
[not found] ` <4F7A0500.3060305-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2012-04-13 22:51 ` Stephen Warren
2012-04-13 22:51 ` Stephen Warren
2012-04-18 14:27 ` Wolfram Sang
2012-04-18 14:27 ` Wolfram Sang
2012-04-18 20:02 ` Stephen Warren [this message]
[not found] ` <4F8F1DBD.8000009-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2012-04-18 20:20 ` Wolfram Sang
2012-04-18 20:20 ` Wolfram Sang
-- strict thread matches above, loose matches on Subject: below --
2011-12-26 11:14 Alok Chauhan
2011-12-26 11:14 ` Alok Chauhan
[not found] ` <1324898081-10308-1-git-send-email-alokc-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2012-01-06 16:18 ` Ben Dooks
2012-01-06 16:18 ` Ben Dooks
2012-01-10 4:12 ` Alok Chauhan
[not found] ` <7A0BFCFE3DA5CD47B0FB7984326F201A134F2CD4F1-kdsAE/FnitNDw2glCA4ptUEOCMrvLtNR@public.gmane.org>
2012-02-10 9:20 ` Alok Chauhan
2012-02-10 9:20 ` Alok Chauhan
2012-02-10 9:35 ` Shubhrajyoti Datta
[not found] ` <CAM=Q2cs+myCvph7OXvCDTG7y48oNTfRtjsDzQaKiEXzjdu3pzA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-02-14 5:49 ` Alok Chauhan
2012-02-14 5:49 ` Alok Chauhan
[not found] ` <7A0BFCFE3DA5CD47B0FB7984326F201A13689D386F-kdsAE/FnitNDw2glCA4ptUEOCMrvLtNR@public.gmane.org>
2012-03-08 6:29 ` Alok Chauhan
2012-03-08 6:29 ` Alok Chauhan
[not found] ` <7A0BFCFE3DA5CD47B0FB7984326F201A136B886672-kdsAE/FnitNDw2glCA4ptUEOCMrvLtNR@public.gmane.org>
2012-03-08 16:30 ` Stephen Warren
[not found] ` <4F58DEB8.9060103-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2012-03-26 21:09 ` Dylan Reid
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F8F1DBD.8000009@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=alokc@nvidia.com \
--cc=ben-linux@fluff.org \
--cc=bones@secretlab.ca \
--cc=ccross@android.com \
--cc=dgreid@chromium.org \
--cc=khali@linux-fr.org \
--cc=ldewangan@nvidia.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=olof@lixom.net \
--cc=omaplinuxkernel@gmail.com \
--cc=swarren@nvidia.com \
--cc=w.sang@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.