From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1SKcOo-0000a1-RU for mharc-grub-devel@gnu.org; Wed, 18 Apr 2012 17:26:50 -0400 Received: from eggs.gnu.org ([208.118.235.92]:46328) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SKcOg-0000QL-4l for grub-devel@gnu.org; Wed, 18 Apr 2012 17:26:48 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SKcOV-0001E5-Lu for grub-devel@gnu.org; Wed, 18 Apr 2012 17:26:41 -0400 Received: from mail-wg0-f49.google.com ([74.125.82.49]:49220) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SKcOV-0001CY-AO for grub-devel@gnu.org; Wed, 18 Apr 2012 17:26:31 -0400 Received: by wgbdr1 with SMTP id dr1so5906306wgb.30 for ; Wed, 18 Apr 2012 14:26:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:user-agent:mime-version:to:subject:references :in-reply-to:x-enigmail-version:content-type; bh=ozkQgsoZldO1DNGpGncyQ92nr95Ls2LoY73Ze0ehFjE=; b=rcnPMDbyhsmCZDKfmMeTLW7ra5ecUuTNVhJ8Mnuku7uXa9O1D5JwY+SlRmS+iQ4QtS D6ng0fnlJI4v3fUv9NXqGOYNxkMnyzGWoXG7lro9qI7OqqUxCwTr9tjTxBn9gFiY8g+w TGOLG3z0tQ4rDMDf+sH24DpF2A9j92PlCPZZI4L/lKsj6sdWVzE8DJZ50/C+6Btu+8Jo hgTPbONVBvsrDBJW3tDbfuXo5NNx8BXzkKorWm9mzIpFVnDRguIJoQOR/PAk9Ps/KsPy RHs7tQoidNUHHy9MjF6Nh5dDzANzxYT3D5YEc24jIgKrTCy2v1zJMJXsdYhxkysAxLyz oBhg== Received: by 10.216.143.209 with SMTP id l59mr2314276wej.87.1334784389293; Wed, 18 Apr 2012 14:26:29 -0700 (PDT) Received: from debian.x201.phnet (79-233.197-178.cust.bluewin.ch. [178.197.233.79]) by mx.google.com with ESMTPS id ff2sm384891wib.9.2012.04.18.14.26.25 (version=TLSv1/SSLv3 cipher=OTHER); Wed, 18 Apr 2012 14:26:28 -0700 (PDT) Message-ID: <4F8F3175.2010408@gmail.com> Date: Wed, 18 Apr 2012 23:26:13 +0200 From: =?UTF-8?B?VmxhZGltaXIgJ8+GLWNvZGVyL3BoY29kZXInIFNlcmJpbmVua28=?= User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:10.0.3) Gecko/20120329 Icedove/10.0.3 MIME-Version: 1.0 To: grub-devel@gnu.org Subject: Re: Improve support for genkernel in 10_linux References: <4F80B7AE.9000607@gentoo.org> <4F84F2D4.9030305@gentoo.org> <4F857384.10907@gmail.com> <4F8A30A0.7060401@gentoo.org> <4F8E8836.7020808@gmail.com> <4F8EDAC1.7040402@gmail.com> In-Reply-To: X-Enigmail-Version: 1.4 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="------------enig086D4AD2221D1033B2901CC1" X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 74.125.82.49 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 18 Apr 2012 21:26:48 -0000 This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig086D4AD2221D1033B2901CC1 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 18.04.2012 17:39, Mike Gilbert wrote: > 2012/4/18 Vladimir '=CF=86-coder/phcoder' Serbinenko : >> On 18.04.2012 17:06, Mike Gilbert wrote: >>> 2012/4/18 Vladimir '=CF=86-coder/phcoder' Serbinenko : >>>> On 15.04.2012 04:21, Mike Gilbert wrote: >>>>> On 04/11/2012 11:52 AM, Mike Gilbert wrote: >>>>>> 2012/4/11 Vladimir '=CF=86-coder/phcoder' Serbinenko : >>>>>>> On 11.04.2012 04:56, Mike Gilbert wrote: >>>>>>>> On 04/07/2012 05:54 PM, Mike Gilbert wrote: >>>>>>>>> Secondly, genkernel looks for the "real_root" kernel command li= ne option >>>>>>>>> to determine the root filesystem. This is a holdover from the d= ays when >>>>>>>>> we used true initrd images and we needed to use root=3D/dev/ram= 0. >>>>>>>>> >>>>>>>> It was brought to my attention that genkernel's initramfs code w= ill in >>>>>>>> fact utilize "root" if "real_root" is unset. This part of my pre= vious >>>>>>>> patch is therefore pointless. >>>>>>>> >>>>>>>> I have attached a revised patch containing only the changes nece= ssary to >>>>>>>> detect a genkernel initramfs image. >>>>>>>> >>>>>>> pushd/popd isn't POSIX so we can't use it in our scripts. Also I = don't >>>>>>> feel like glob expansion is the right thing to use here. Why not = infer >>>>>>> the architecture from uname ? >>>>>> That should also work. Here's the logic that genkernel uses to pop= ulate ARCH: >>>>>> >>>>>> ARCH=3D`uname -m` >>>>>> case "${ARCH}" in >>>>>> i?86) >>>>>> ARCH=3D"x86" >>>>>> ;; >>>>>> mips|mips64) >>>>>> ARCH=3D"mips" >>>>>> ;; >>>>>> arm*) >>>>>> ARCH=3Darm >>>>>> ;; >>>>>> *) >>>>>> ;; >>>>>> esac >>>>>> >>>>>> I'm thinking it would be a good idea to rename ARCH to something l= ike >>>>>> GENKERNEL_ARCH. We should also let the user override this in >>>>>> /etc/default/grub. >>>>>> >>>>>> Does that sound ok? >>>>> I have modified my patch to implement what I describe above. >>>>> >>>> What is the reason to make it configurable? There shouldn't be any n= eed >>>> to configure something that is autodetected >>>> >>> genkernel allows the user to cross-compile their kernel and/or >>> initramfs, in which case uname -m would not provide the correct value= =2E >>> >>> I don't have a clear picture in my mind of how that would work with >>> grub, but I figure it would be better to err on the side of >>> flexibility. >> grub-mkconfig doesn't support cross-configuration and arch name is jus= t >> one of the problems. Unless we have a designed system for this case it= 's >> useless to add stray bits which don't work anyway. >> > Alright, not a bit deal. Do you need a new patch from me? I've fixed it myself. Also I've kept the incorrect names for backwards compatibility and since they create no problem > _______________________________________________ > Grub-devel mailing list > Grub-devel@gnu.org > https://lists.gnu.org/mailman/listinfo/grub-devel --=20 Regards Vladimir '=CF=86-coder/phcoder' Serbinenko --------------enig086D4AD2221D1033B2901CC1 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iF4EAREKAAYFAk+PMXUACgkQNak7dOguQgny+QD7BLyF4cBHqLFlhWDL0lBT66B1 Fy0irkGQKSk9Bs5IXLEA/ie50PrDgKWNSoIj7QzuPcI5o8/HqwxBMyuEc+nGvss+ =YiTB -----END PGP SIGNATURE----- --------------enig086D4AD2221D1033B2901CC1--