All of lore.kernel.org
 help / color / mirror / Atom feed
From: Timur Tabi <b04825@freescale.com>
To: Huang Changming-R66093 <r66093@freescale.com>
Cc: "linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>
Subject: Re: [PATCH v2 1/2] powerpc/mpc85xx: support the MTD for p1022ds flash
Date: Wed, 18 Apr 2012 17:01:32 -0500	[thread overview]
Message-ID: <4F8F39BC.5090800@freescale.com> (raw)
In-Reply-To: <110EED8CC96DFC488B7E717A2027A27C079DD8@039-SN1MPN1-002.039d.mgd.msft.net>

Huang Changming-R66093 wrote:
> But, I observed the Call Trace, but the partition can be parsed correctly.
> Maybe your patch can fix this Call Trace.

Can you post the call trace?

I think the reason this patch works is because the localbus node is not
already probed by mpc85xx_common_publish_devices().
mpc85xx_common_publish_devices() has this line in it:

	{ .name = "localbus", },

But this does not work any more, because all of our 85xx localbus nodes
are now called "localbus@ffe05000".

I'm beginning to hate mpc85xx_common_publish_devices() now.  Not only
because it's broken for the P1022DS, but also because it's not
set-in-stone like everyone thought.

-- 
Timur Tabi
Linux kernel developer at Freescale

      reply	other threads:[~2012-04-18 22:01 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-17  9:15 [PATCH v2 1/2] powerpc/mpc85xx: support the MTD for p1022ds flash Chang-Ming.Huang
2012-04-17 18:09 ` Tabi Timur-B04825
2012-04-18  7:46   ` Huang Changming-R66093
2012-04-18  8:02     ` Huang Changming-R66093
2012-04-18 22:01       ` Timur Tabi [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F8F39BC.5090800@freescale.com \
    --to=b04825@freescale.com \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=r66093@freescale.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.