Re: [PATCH] ARM: SAMSUNG: Should check for IS_ERR(clk) instead of NULL

[Kukjin Kim <kgene.kim@samsung.com>]

jhbird.choi@gmail.com wrote:
> From: Jonghwan Choi<jhbird.choi@samsung.com>
> 
> On the error condition clk_get() returns ERR_PTR().
> 
> Signed-off-by: Jonghwan Choi<jhbird.choi@samsung.com>
> ---
>   .../arm/plat-samsung/include/plat/watchdog-reset.h |    2 +-
>   1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/arch/arm/plat-samsung/include/plat/watchdog-reset.h b/arch/arm/plat-samsung/include/plat/watchdog-reset.h
> index f19aff1..bc4db9b 100644
> --- a/arch/arm/plat-samsung/include/plat/watchdog-reset.h
> +++ b/arch/arm/plat-samsung/include/plat/watchdog-reset.h
> @@ -25,7 +25,7 @@ static inline void arch_wdt_reset(void)
> 
>   	__raw_writel(0, S3C2410_WTCON);	  /* disable watchdog, to be safe  */
> 
> -	if (s3c2410_wdtclk)
> +	if (!IS_ERR(s3c2410_wdtclk))

Yeah, right. BTW don't we need to check NULL here?

>   		clk_enable(s3c2410_wdtclk);
> 
>   	/* put initial values into count and data */

Thanks.

Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.