From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kukjin Kim Subject: Re: [PATCH 02/12] ARM: Exynos5: Fix incorrect initialization of GIC Date: Wed, 18 Apr 2012 17:51:27 -0700 Message-ID: <4F8F618F.2070603@samsung.com> References: <1334641595-25301-1-git-send-email-thomas.abraham@linaro.org> <1334641595-25301-3-git-send-email-thomas.abraham@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset=EUC-KR Content-Transfer-Encoding: 7bit Return-path: Received: from mail-pz0-f52.google.com ([209.85.210.52]:33279 "EHLO mail-pz0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754172Ab2DSAv2 (ORCPT ); Wed, 18 Apr 2012 20:51:28 -0400 Received: by dake40 with SMTP id e40so10582752dak.11 for ; Wed, 18 Apr 2012 17:51:27 -0700 (PDT) In-Reply-To: <1334641595-25301-3-git-send-email-thomas.abraham@linaro.org> Sender: linux-samsung-soc-owner@vger.kernel.org List-Id: linux-samsung-soc@vger.kernel.org To: Thomas Abraham Cc: linux-samsung-soc@vger.kernel.org, kgene.kim@samsung.com, linux-arm-kernel@lists.infradead.org, chaos.youn@samsung.com Thomas Abraham wrote: > Use the of_irq_init() call to setup the gic which also properly registers > the gic device node pointer with gic irq domain, without which all interrupt > specifier translations for gic fail. > > Signed-off-by: Thomas Abraham > --- > arch/arm/mach-exynos/common.c | 4 +++- > 1 files changed, 3 insertions(+), 1 deletions(-) > > diff --git a/arch/arm/mach-exynos/common.c b/arch/arm/mach-exynos/common.c > index 636d5f8..35ac675 100644 > --- a/arch/arm/mach-exynos/common.c > +++ b/arch/arm/mach-exynos/common.c > @@ -532,11 +532,12 @@ void __init exynos4_init_irq(void) > s5p_init_irq(NULL, 0); > } > > +#ifdef CONFIG_ARCH_EXYNOS5 Why this is needed? > void __init exynos5_init_irq(void) > { > int irq; > > - gic_init(0, IRQ_PPI(0), S5P_VA_GIC_DIST, S5P_VA_GIC_CPU); > + of_irq_init(exynos4_dt_irq_match); > > for (irq = 0; irq< EXYNOS5_MAX_COMBINER_NR; irq++) { > combiner_init(irq, (void __iomem *)S5P_VA_COMBINER(irq), > @@ -551,6 +552,7 @@ void __init exynos5_init_irq(void) > */ > s5p_init_irq(NULL, 0); > } > +#endif /* CONFIG_ARCH_EXYNOS5 */ > > struct bus_type exynos4_subsys = { > .name = "exynos4-core", Thanks. Best regards, Kgene. -- Kukjin Kim , Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd. From mboxrd@z Thu Jan 1 00:00:00 1970 From: kgene.kim@samsung.com (Kukjin Kim) Date: Wed, 18 Apr 2012 17:51:27 -0700 Subject: [PATCH 02/12] ARM: Exynos5: Fix incorrect initialization of GIC In-Reply-To: <1334641595-25301-3-git-send-email-thomas.abraham@linaro.org> References: <1334641595-25301-1-git-send-email-thomas.abraham@linaro.org> <1334641595-25301-3-git-send-email-thomas.abraham@linaro.org> Message-ID: <4F8F618F.2070603@samsung.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Thomas Abraham wrote: > Use the of_irq_init() call to setup the gic which also properly registers > the gic device node pointer with gic irq domain, without which all interrupt > specifier translations for gic fail. > > Signed-off-by: Thomas Abraham > --- > arch/arm/mach-exynos/common.c | 4 +++- > 1 files changed, 3 insertions(+), 1 deletions(-) > > diff --git a/arch/arm/mach-exynos/common.c b/arch/arm/mach-exynos/common.c > index 636d5f8..35ac675 100644 > --- a/arch/arm/mach-exynos/common.c > +++ b/arch/arm/mach-exynos/common.c > @@ -532,11 +532,12 @@ void __init exynos4_init_irq(void) > s5p_init_irq(NULL, 0); > } > > +#ifdef CONFIG_ARCH_EXYNOS5 Why this is needed? > void __init exynos5_init_irq(void) > { > int irq; > > - gic_init(0, IRQ_PPI(0), S5P_VA_GIC_DIST, S5P_VA_GIC_CPU); > + of_irq_init(exynos4_dt_irq_match); > > for (irq = 0; irq< EXYNOS5_MAX_COMBINER_NR; irq++) { > combiner_init(irq, (void __iomem *)S5P_VA_COMBINER(irq), > @@ -551,6 +552,7 @@ void __init exynos5_init_irq(void) > */ > s5p_init_irq(NULL, 0); > } > +#endif /* CONFIG_ARCH_EXYNOS5 */ > > struct bus_type exynos4_subsys = { > .name = "exynos4-core", Thanks. Best regards, Kgene. -- Kukjin Kim , Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd.