Re: [PATCH] hfp_hf: Fix modifying hash table while iterating

[Denis Kenzior <denkenz@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 1037 bytes --]

Hi Mikel,

>> The patch looks absolutely fine, however can you check whether removing
>> g_hashtable_remove from hfp_remove would do the trick as well?  We don't
>> seem to be doing this in the sap driver, and I no longer recall whether
>> this was done in hfp_hf to keep valgrind happy or is simply a mistake.
> 
> I was reluctant to make such a change because I wasn't entirely sure about
> which assumptions are made by the core about modem removals.
> 
> If we know that all calls to ofono_modem_remove() will be originated in
> hfp_hf.c, then your proposal would just work. I will send the corresponding
> patch soon.

The core does not call ofono_modem_remove on its own, this is triggered
by the plugins (e.g. udev, bluetooth).  So Under normal circumstances
all calls to ofono_modem_remove would be triggered by BlueZ reporting
something, e.g. adapter removed, device removed, etc.

The only time this might be a problem is during shutdown, hence my
comment about keeping valgrind happy.

Regards,
-Denis