From: Johannes Sixt <j.sixt@viscovery.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: Jeff King <peff@peff.net>,
Ben Walton <bwalton@artsci.utoronto.ca>,
jrnieder@gmail.com, git@vger.kernel.org
Subject: Re: [PATCH] Do not use SHELL_PATH from build system in prepare_shell_cmd on Windows
Date: Thu, 19 Apr 2012 07:36:19 +0200 [thread overview]
Message-ID: <4F8FA453.8050807@viscovery.net> (raw)
In-Reply-To: <7vobqpknoq.fsf@alter.siamese.dyndns.org>
Am 4/18/2012 18:30, schrieb Junio C Hamano:
> There is one thing I am confused about your response, though. I thought
> the suggestion by Peff was to build your binary with "make SHELL_PATH=sh"
> (not "make SHELL_PATH=/bin/sh"). I do not know if that works or does not
> work (I do not see why not, though), but in either case offering a new
> customization point sounds like a separate issue.
I tried this, and it does not work. (Shell scripts' shbang line would end
up as '#!sh', and at least bash does not like to run such scripts.)
The alternative is to customize the -DSHELL_PATH=... compiler option for
Windows, and that is primarily what I don't like: It would mean that
either the name "SHELL_PATH" has different meaning in C code and the
Makefile, or we need a new name for the C macro. (The latter would be "a
new customization point".)
I learn from this conversation that I should note failed alternatives more
frequently in the commit message to save reviewers' time.
-- Hannes
next prev parent reply other threads:[~2012-04-19 5:36 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <7vvclmoit6.fsf@alter.siamese.dyndns.org>
2012-03-31 1:33 ` [PATCH] Use SHELL_PATH from build system in run_command.c:prepare_shell_cmd Ben Walton
2012-03-31 3:48 ` Jonathan Nieder
2012-03-31 5:38 ` Junio C Hamano
2012-03-31 5:55 ` Jonathan Nieder
2012-03-31 17:49 ` Junio C Hamano
2012-03-31 18:04 ` Junio C Hamano
2012-04-17 7:03 ` [PATCH] Do not use SHELL_PATH from build system in prepare_shell_cmd on Windows Johannes Sixt
2012-04-17 13:45 ` Ben Walton
2012-04-17 14:00 ` Johannes Sixt
2012-04-17 14:04 ` Ben Walton
2012-04-17 22:14 ` Jeff King
2012-04-18 5:39 ` Johannes Sixt
2012-04-18 7:27 ` Jeff King
2012-04-18 16:30 ` Junio C Hamano
2012-04-19 5:36 ` Johannes Sixt [this message]
2012-04-19 5:49 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F8FA453.8050807@viscovery.net \
--to=j.sixt@viscovery.net \
--cc=bwalton@artsci.utoronto.ca \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jrnieder@gmail.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.