From mboxrd@z Thu Jan 1 00:00:00 1970 From: Giuseppe CAVALLARO Subject: Re: [PATCH] stmmac: fix kernel crash when device probed for SPEAr with DT Date: Thu, 19 Apr 2012 07:51:48 +0200 Message-ID: <4F8FA7F4.9000505@st.com> References: <91ea900ce78bb2054d83e0575c16ac70f3f11511.1334654597.git.viresh.kumar@st.com> <4F8E4CEC.9050002@st.com> <4F8E4DD3.8030908@st.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: spear-devel , "viresh.linux@gmail.com" , "netdev@vger.kernel.org" , "davem@davemloft.net" , Deepak SIKRI To: Viresh Kumar Return-path: Received: from eu1sys200aog104.obsmtp.com ([207.126.144.117]:36295 "EHLO eu1sys200aog104.obsmtp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751300Ab2DSFx1 (ORCPT ); Thu, 19 Apr 2012 01:53:27 -0400 In-Reply-To: <4F8E4DD3.8030908@st.com> Sender: netdev-owner@vger.kernel.org List-ID: Hello Viresh. On 4/18/2012 7:14 AM, Viresh Kumar wrote: > On 4/18/2012 10:41 AM, Giuseppe CAVALLARO wrote: >> I hoped it was fully tested on SPEAr platforms. at any rate > > I am only working for SPEAr3xx with DT support and this patch is must as > without it we have build failures. Haven't tested on any other SPEAr SoCs, they > may require extra pdata fields to be initialized, but that will follow with > their DT support. > I've just sent 4 patches so I kindly ask you to review the patch named: [net-next 3/4] stmmac: verify the dma_cfg platform fields where I reworked the logic behind the dma_cfg conf. Peppe