From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.saout.de ([127.0.0.1]) by localhost (mail.saout.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id kZnUte38xqKa for ; Thu, 19 Apr 2012 09:53:10 +0200 (CEST) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mail.saout.de (Postfix) with ESMTP for ; Thu, 19 Apr 2012 09:53:09 +0200 (CEST) Message-ID: <4F8FC45D.7070706@redhat.com> Date: Thu, 19 Apr 2012 09:53:01 +0200 From: Milan Broz MIME-Version: 1.0 References: In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [dm-crypt] comment on API for saving and restoring luks header. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: ".. ink .." Cc: dm-crypt@saout.de On 04/18/2012 11:19 PM, .. ink .. wrote: > > /** > * Backup header and keyslots to file > * > * @param cd crypt device handle > * @param requested_type type of header to backup > * @param backup_file file to backup header to > * > * @return @e 0 on success or negative errno value otherwise. > * > */ > > The above is a comments on options for "crypt_header_backup" and "crypt_header_restore". > > The comment does not have "use @e NULL for all known" explanation for the second argument. > > Should i assume this is an oversight and use "NULL" for the second argument? The only format currently supporting this is LUKS anyway, but NULL is supported. Better now? http://wiki.cryptsetup.googlecode.com/git/API/libcryptsetup_8h.html#a0bba6108652c028e6e72e933a3a5de05 Milan