From: Lars-Peter Clausen <lars@metafoo.de>
To: Laxman Dewangan <ldewangan@nvidia.com>
Cc: jic23@cam.ac.uk, gregkh@linuxfoundation.org, max@stro.at,
jbrenner@taosinc.com, bfreed@chromium.org, grundler@chromium.org,
linux-iio@vger.kernel.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH V2 2/2] staging: iio: light: isl29018: use regmap for register access
Date: Thu, 19 Apr 2012 11:56:29 +0200 [thread overview]
Message-ID: <4F8FE14D.6010005@metafoo.de> (raw)
In-Reply-To: <1334825975-7062-3-git-send-email-ldewangan@nvidia.com>
On 04/19/2012 10:59 AM, Laxman Dewangan wrote:
> [...]
> -static int isl29018_read_sensor_input(struct i2c_client *client, int mode)
> +static int isl29018_read_sensor_input(struct isl29018_chip *chip, int mode)
> {
> [...]
> - dev_err(&client->dev, "Error in reading MSB DATA\n");
> + status = regmap_read(chip->regmap, ISL29018_REG_ADD_DATA_MSB, &msb);
> + if (status < 0) {
> + dev_err(chip->dev,
> + "Error in reading MSB DATA with error %d\n", status);
> return msb;
should return status instead of msb.
> [...]
prev parent reply other threads:[~2012-04-19 9:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-19 8:59 [PATCH V2 0/2] staging: iio: light: use regmap in isl29018 for register access Laxman Dewangan
2012-04-19 8:59 ` [PATCHi V2 1/2] staging: iio: light: convert multiple spaces to tab Laxman Dewangan
2012-04-19 12:49 ` Jonathan Cameron
2012-04-20 15:30 ` Greg KH
2012-04-19 8:59 ` [PATCH V2 2/2] staging: iio: light: isl29018: use regmap for register access Laxman Dewangan
2012-04-19 9:56 ` Lars-Peter Clausen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F8FE14D.6010005@metafoo.de \
--to=lars@metafoo.de \
--cc=bfreed@chromium.org \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=grundler@chromium.org \
--cc=jbrenner@taosinc.com \
--cc=jic23@cam.ac.uk \
--cc=ldewangan@nvidia.com \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=max@stro.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.