From: Oliver Hartkopp <socketcan@hartkopp.net>
To: Marc Kleine-Budde <mkl@pengutronix.de>
Cc: yegorslists@googlemail.com, linux-can@vger.kernel.org
Subject: Re: [PATCH] candump: resolve signedness warnings
Date: Thu, 19 Apr 2012 17:46:42 +0200 [thread overview]
Message-ID: <4F903362.3070703@hartkopp.net> (raw)
In-Reply-To: <4F8FD2C1.8010903@pengutronix.de>
On 19.04.2012 10:54, Marc Kleine-Budde wrote:
> On 04/19/2012 09:44 AM, yegorslists@googlemail.com wrote:
>> From: Yegor Yefremov <yegorslists@googlemail.com>
>>
>> Signed-off-by: Yegor Yefremov <yegorslists@googlemail.com>
>
> nbytes has been tested before if it's < 0, so it's safe to cast it to an
> unsigned value.
>
> Acked-by: Marc Kleine-Budde <mkl@pengutronix.de>
>
> Oliver do you want to take the patch?
Yes. I applied it to the git repo.
I did it with
git am --signoff < candump.patch
using the original mail from Yegor.
Unfortunately that missed your Acked-by: ...
What would be the right way to apply it with your Acked-by too?
I assume applying your answered mail won't have made it, right?
Regards,
Oliver
next prev parent reply other threads:[~2012-04-19 15:46 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-19 7:44 [PATCH] candump: resolve signedness warnings yegorslists
2012-04-19 8:54 ` Marc Kleine-Budde
2012-04-19 15:46 ` Oliver Hartkopp [this message]
2012-04-19 15:57 ` Marc Kleine-Budde
2012-04-19 16:01 ` Wolfram Sang
2012-04-19 16:03 ` Marc Kleine-Budde
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F903362.3070703@hartkopp.net \
--to=socketcan@hartkopp.net \
--cc=linux-can@vger.kernel.org \
--cc=mkl@pengutronix.de \
--cc=yegorslists@googlemail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.