* [PATCH] drivers/tty/amiserial.c: add missing tty_unlock
@ 2012-04-19 16:12 ` Julia Lawall
0 siblings, 0 replies; 4+ messages in thread
From: Julia Lawall @ 2012-04-19 16:12 UTC (permalink / raw)
To: Greg Kroah-Hartman; +Cc: kernel-janitors, linux-kernel
From: Julia Lawall <Julia.Lawall@lip6.fr>
tty_unlock is used on all other exits from the function.
Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
---
drivers/tty/amiserial.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/tty/amiserial.c b/drivers/tty/amiserial.c
index 24145c3..6cc4358 100644
--- a/drivers/tty/amiserial.c
+++ b/drivers/tty/amiserial.c
@@ -1073,8 +1073,10 @@ static int set_serial_info(struct tty_struct *tty, struct serial_state *state,
(new_serial.close_delay != port->close_delay) ||
(new_serial.xmit_fifo_size != state->xmit_fifo_size) ||
((new_serial.flags & ~ASYNC_USR_MASK) !- (port->flags & ~ASYNC_USR_MASK)))
+ (port->flags & ~ASYNC_USR_MASK))) {
+ tty_unlock();
return -EPERM;
+ }
port->flags = ((port->flags & ~ASYNC_USR_MASK) |
(new_serial.flags & ASYNC_USR_MASK));
state->custom_divisor = new_serial.custom_divisor;
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH] drivers/tty/amiserial.c: add missing tty_unlock
@ 2012-04-19 16:12 ` Julia Lawall
0 siblings, 0 replies; 4+ messages in thread
From: Julia Lawall @ 2012-04-19 16:12 UTC (permalink / raw)
To: Greg Kroah-Hartman; +Cc: kernel-janitors, linux-kernel
From: Julia Lawall <Julia.Lawall@lip6.fr>
tty_unlock is used on all other exits from the function.
Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
---
drivers/tty/amiserial.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/tty/amiserial.c b/drivers/tty/amiserial.c
index 24145c3..6cc4358 100644
--- a/drivers/tty/amiserial.c
+++ b/drivers/tty/amiserial.c
@@ -1073,8 +1073,10 @@ static int set_serial_info(struct tty_struct *tty, struct serial_state *state,
(new_serial.close_delay != port->close_delay) ||
(new_serial.xmit_fifo_size != state->xmit_fifo_size) ||
((new_serial.flags & ~ASYNC_USR_MASK) !=
- (port->flags & ~ASYNC_USR_MASK)))
+ (port->flags & ~ASYNC_USR_MASK))) {
+ tty_unlock();
return -EPERM;
+ }
port->flags = ((port->flags & ~ASYNC_USR_MASK) |
(new_serial.flags & ASYNC_USR_MASK));
state->custom_divisor = new_serial.custom_divisor;
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] drivers/tty/amiserial.c: add missing tty_unlock
2012-04-19 16:12 ` Julia Lawall
@ 2012-04-19 20:19 ` Jiri Slaby
-1 siblings, 0 replies; 4+ messages in thread
From: Jiri Slaby @ 2012-04-19 20:19 UTC (permalink / raw)
To: Julia Lawall; +Cc: Greg Kroah-Hartman, kernel-janitors, linux-kernel
On 04/19/2012 06:12 PM, Julia Lawall wrote:
> From: Julia Lawall <Julia.Lawall@lip6.fr>
>
> tty_unlock is used on all other exits from the function.
>
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Acked-by: Jiri Slaby <jslaby@suse.cz>
This is broken since 2008 BTW.
> ---
> drivers/tty/amiserial.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/tty/amiserial.c b/drivers/tty/amiserial.c
> index 24145c3..6cc4358 100644
> --- a/drivers/tty/amiserial.c
> +++ b/drivers/tty/amiserial.c
> @@ -1073,8 +1073,10 @@ static int set_serial_info(struct tty_struct *tty, struct serial_state *state,
> (new_serial.close_delay != port->close_delay) ||
> (new_serial.xmit_fifo_size != state->xmit_fifo_size) ||
> ((new_serial.flags & ~ASYNC_USR_MASK) !> - (port->flags & ~ASYNC_USR_MASK)))
> + (port->flags & ~ASYNC_USR_MASK))) {
> + tty_unlock();
> return -EPERM;
> + }
> port->flags = ((port->flags & ~ASYNC_USR_MASK) |
> (new_serial.flags & ASYNC_USR_MASK));
> state->custom_divisor = new_serial.custom_divisor;
--
js
suse labs
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] drivers/tty/amiserial.c: add missing tty_unlock
@ 2012-04-19 20:19 ` Jiri Slaby
0 siblings, 0 replies; 4+ messages in thread
From: Jiri Slaby @ 2012-04-19 20:19 UTC (permalink / raw)
To: Julia Lawall; +Cc: Greg Kroah-Hartman, kernel-janitors, linux-kernel
On 04/19/2012 06:12 PM, Julia Lawall wrote:
> From: Julia Lawall <Julia.Lawall@lip6.fr>
>
> tty_unlock is used on all other exits from the function.
>
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Acked-by: Jiri Slaby <jslaby@suse.cz>
This is broken since 2008 BTW.
> ---
> drivers/tty/amiserial.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/tty/amiserial.c b/drivers/tty/amiserial.c
> index 24145c3..6cc4358 100644
> --- a/drivers/tty/amiserial.c
> +++ b/drivers/tty/amiserial.c
> @@ -1073,8 +1073,10 @@ static int set_serial_info(struct tty_struct *tty, struct serial_state *state,
> (new_serial.close_delay != port->close_delay) ||
> (new_serial.xmit_fifo_size != state->xmit_fifo_size) ||
> ((new_serial.flags & ~ASYNC_USR_MASK) !=
> - (port->flags & ~ASYNC_USR_MASK)))
> + (port->flags & ~ASYNC_USR_MASK))) {
> + tty_unlock();
> return -EPERM;
> + }
> port->flags = ((port->flags & ~ASYNC_USR_MASK) |
> (new_serial.flags & ASYNC_USR_MASK));
> state->custom_divisor = new_serial.custom_divisor;
--
js
suse labs
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2012-04-19 20:19 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-04-19 16:12 [PATCH] drivers/tty/amiserial.c: add missing tty_unlock Julia Lawall
2012-04-19 16:12 ` Julia Lawall
2012-04-19 20:19 ` Jiri Slaby
2012-04-19 20:19 ` Jiri Slaby
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.