From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mauro Carvalho Chehab Subject: Re: [PATCH v4 02/14] Documentation: media: description of DMABUF importing in V4L2 Date: Thu, 19 Apr 2012 17:36:39 -0300 Message-ID: <4F907757.4090709@redhat.com> References: <1334332076-28489-1-git-send-email-t.stanislaws@samsung.com> <1334332076-28489-3-git-send-email-t.stanislaws@samsung.com> <13761406.oTf8ZzmZpQ@avalon> <4F9021FE.2070903@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <4F9021FE.2070903@samsung.com> Sender: linux-media-owner@vger.kernel.org To: Tomasz Stanislawski Cc: Laurent Pinchart , linux-media@vger.kernel.org, dri-devel@lists.freedesktop.org, airlied@redhat.com, m.szyprowski@samsung.com, kyungmin.park@samsung.com, sumit.semwal@ti.com, daeinki@gmail.com, daniel.vetter@ffwll.ch, robdclark@gmail.com, pawel@osciak.com, linaro-mm-sig@lists.linaro.org, hverkuil@xs4all.nl, remi@remlab.net, subashrp@gmail.com List-Id: dri-devel@lists.freedesktop.org Em 19-04-2012 11:32, Tomasz Stanislawski escreveu: > On 04/17/2012 01:25 AM, Laurent Pinchart wrote: >> Hi Tomasz, >> >> Thanks for the patch. >> >> On Friday 13 April 2012 17:47:44 Tomasz Stanislawski wrote: >>> This patch adds description and usage examples for importing >>> DMABUF file descriptor in V4L2. >>> >>> Signed-off-by: Tomasz Stanislawski >>> Signed-off-by: Kyungmin Park >> >> [snip] >> >>> diff --git a/Documentation/DocBook/media/v4l/io.xml >>> b/Documentation/DocBook/media/v4l/io.xml index b815929..dc5979d 100644 >>> --- a/Documentation/DocBook/media/v4l/io.xml >>> +++ b/Documentation/DocBook/media/v4l/io.xml >>> @@ -472,6 +472,162 @@ rest should be evident. >>> >>> >>> >>> +
>>> + Streaming I/O (DMA buffer importing) >> >> This section is very similar to the Streaming I/O (User Pointers) section. Do >> you think we should merge the two ? I could handle that if you want. >> > > Hi Laurent, > > One may find similar sentences in MMAP, USERPTR and DMABUF. > Maybe the common parts like description of STREAMON/OFF, > QBUF/DQBUF shuffling should be moved to separate section > like "Streaming" :). > > Maybe it is worth to introduce a separate patch for this change. > > Frankly, I would prefer to keep the Doc in the current form till > importer support gets merged. Later the Doc could be fixed. > > BTW. What is the sense of merging userptr and dmabuf section > if userptr is going to dropped in long-term? I didn't read the rest of the thread, so sorry, if I'm making wrong assumptions... Am I understanding wrong or are you saying that you want to drop userptr from V4L2 API in long-term? > > Regards, > Tomasz Stanislawski