From mboxrd@z Thu Jan 1 00:00:00 1970 From: Suresh Jayaraman Subject: Re: [PATCH] mount.cifs: remove unnecessary getuid() check in libcap version of toggle_dac_capability Date: Fri, 20 Apr 2012 11:04:21 +0530 Message-ID: <4F90F55D.30909@suse.com> References: <1334863493-18978-1-git-send-email-jlayton@samba.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: linux-cifs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, lmuelle-IBi9RG/b67k@public.gmane.org To: Jeff Layton Return-path: In-Reply-To: <1334863493-18978-1-git-send-email-jlayton-eUNUBHrolfbYtjvyW6yDsg@public.gmane.org> Sender: linux-cifs-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-ID: On 04/20/2012 12:54 AM, Jeff Layton wrote: > I'm not sure what I was thinking when I added that check in, but it's > been there since the inception. We shouldn't care at all what the > real uid is when we call toggle_dac_capability and indeed we don't > care with the libcap-ng version. Remove that check. No specific comments on the patch itself but I don't understand the changelog. This code corresponds to the #else part of #ifdef HAVE_LIBCAP_NG and doesn't have any relevance to the libcap-ng? Or did you mean we didn't have to consider this check for #ifdef HAVE_LIBCAP_NG part? Thanks Suresh > Signed-off-by: Jeff Layton > --- > mount.cifs.c | 3 --- > 1 files changed, 0 insertions(+), 3 deletions(-) > > diff --git a/mount.cifs.c b/mount.cifs.c > index 06715dd..c90ce3e 100644 > --- a/mount.cifs.c > +++ b/mount.cifs.c > @@ -552,9 +552,6 @@ toggle_dac_capability(int writable, int enable) > cap_t caps; > cap_value_t capability = writable ? CAP_DAC_OVERRIDE : CAP_DAC_READ_SEARCH; > > - if (getuid() != 0) > - return 0; > - > caps = cap_get_proc(); > if (caps == NULL) { > fprintf(stderr, "Unable to get current capability set: %s\n",