From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1SLCrJ-0000ww-DK for mharc-grub-devel@gnu.org; Fri, 20 Apr 2012 08:22:41 -0400 Received: from eggs.gnu.org ([208.118.235.92]:53905) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SLCrC-0000qQ-8c for grub-devel@gnu.org; Fri, 20 Apr 2012 08:22:39 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SLCr9-0001WX-Ue for grub-devel@gnu.org; Fri, 20 Apr 2012 08:22:33 -0400 Received: from mail-we0-f169.google.com ([74.125.82.169]:52299) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SLCr9-0001Vj-Lt for grub-devel@gnu.org; Fri, 20 Apr 2012 08:22:31 -0400 Received: by werj55 with SMTP id j55so7830624wer.0 for ; Fri, 20 Apr 2012 05:22:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:user-agent:mime-version:to:subject:references :in-reply-to:x-enigmail-version:content-type; bh=jNyVIzN5WupYSPRqtoLfONzLulqF+csHREo3Z1rs5DA=; b=U6dlEYTrdV+oPEGeM66s2F119gS4tcukcYwv4Q+y8buuxpcyqE3b4leMP6nC8Wh/lk tnHk/HUPZjOcc/q0UzFTT8oyJBJQSep1TQlC1aNMXA5+VG85cHcb+lUZDt0E0FUFR4+J XLVPRDJoU5UmKxqlVJzBXIr4PzeGoT6zkQaP1Uk9yBFZP9YuYRJxUjxXG2KCRE+6fKoI fSUI/03J2EJuQ27ThqRrsDZSDBYs2sTebJWMzEtc1Vk9WOkpVihz3tF2/UfvnH1aSCuR 75B3J8B6oZ+Dniv6ZUt6stgRqXWJuGdE9SshmtHt/E3SdeUALOJlT5uIAzk60E7Rk8Vp SOCg== Received: by 10.216.133.39 with SMTP id p39mr3628437wei.40.1334924548636; Fri, 20 Apr 2012 05:22:28 -0700 (PDT) Received: from debian.x201.phnet (39-232.197-178.cust.bluewin.ch. [178.197.232.39]) by mx.google.com with ESMTPS id e6sm5124567wix.8.2012.04.20.05.22.26 (version=TLSv1/SSLv3 cipher=OTHER); Fri, 20 Apr 2012 05:22:27 -0700 (PDT) Message-ID: <4F915500.7020409@gmail.com> Date: Fri, 20 Apr 2012 14:22:24 +0200 From: =?UTF-8?B?VmxhZGltaXIgJ8+GLWNvZGVyL3BoY29kZXInIFNlcmJpbmVua28=?= User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:10.0.3) Gecko/20120329 Icedove/10.0.3 MIME-Version: 1.0 To: grub-devel@gnu.org Subject: Re: [PATCH] fix grub-probe fail on by-(id|uuid|path) device names References: <20120420114048.GA31890@linux-dsax.tai.apac.novell.com> In-Reply-To: <20120420114048.GA31890@linux-dsax.tai.apac.novell.com> X-Enigmail-Version: 1.4 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="------------enig4763CA9961343B7766B1F60A" X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 74.125.82.169 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 20 Apr 2012 12:22:40 -0000 This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig4763CA9961343B7766B1F60A Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 20.04.2012 13:40, Michael Chang wrote: > This patch fixes grub-probe fails on probing devices under > /dev/disk/by-id and other similar mount-by alias names. The method > used to determine the whole disk is by it's name without numeric > character end, but this may be wrong for the by-(id|uuid|path) names > as they are not necessary ended without numeric character. For > instance, my disk was named > "/dev/disk/by-id/ata-WDC_WD1600BEKT-60V5T1_WD-WXK0A69Y4761". > > The fix is use resolved link to kernel device names (like /dev/sda) > instead of these alias names. > > Downstream bug: > https://bugzilla.novell.com/show_bug.cgi?id=3D757746 This patch isn't correct. One of the problems is the use of PATH_MAX instead of our own realpath wrapper. Another, more serious one is that realpath would transform a symlink to any of /dev/mapper/* to dm-X which isn't really usable. Instead we should find out how the untransformed name landed into this part. > > > _______________________________________________ > Grub-devel mailing list > Grub-devel@gnu.org > https://lists.gnu.org/mailman/listinfo/grub-devel --=20 Regards Vladimir '=CF=86-coder/phcoder' Serbinenko --------------enig4763CA9961343B7766B1F60A Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iF4EAREKAAYFAk+RVQAACgkQNak7dOguQgkTLAD/eL6BqBd6lIZ6P+b0Z4DuynXP cAmRrwVlozuqbxramVsBAIh29in8wTikvjMWcG8r8bqy3ikv1U7szVs9YryQYZJG =ECzt -----END PGP SIGNATURE----- --------------enig4763CA9961343B7766B1F60A--