From: Lars-Peter Clausen <lars@metafoo.de>
To: Roland Stigge <stigge@antcom.de>
Cc: jic23@cam.ac.uk, gregkh@linuxfoundation.org,
grant.likely@secretlab.ca, rob.herring@calxeda.com,
linux-iio@vger.kernel.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH RESEND v3] iio: Add device tree support to LPC32xx ADC
Date: Fri, 20 Apr 2012 17:04:03 +0200 [thread overview]
Message-ID: <4F917AE3.7050808@metafoo.de> (raw)
In-Reply-To: <1334932713-19231-1-git-send-email-stigge@antcom.de>
> [...]
>
> --- /dev/null
> +++ linux-2.6/Documentation/devicetree/bindings/staging/iio/adc/lpc32xx-adc.txt
> @@ -0,0 +1,16 @@
> +* NXP LPC32xx SoC ADC controller
> +
> +Required properties:
> +- compatible: must be "nxp,lpc32xx-adc"
> +- reg: physical base address of the controller and length of memory mapped
> + region.
> +- interrupts: The ADC interrupt
> +
> +Example:
> +
> + adc@40048000 {
> + compatible = "nxp,lpc32xx-adc";
In my opinion it seems to be a bad idea to use wildcard names in devicetree
compatible strings.
> + reg = <0x40048000 0x1000>;
> + interrupt-parent = <&mic>;
> + interrupts = <39 0>;
> + };
next prev parent reply other threads:[~2012-04-20 15:01 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-20 14:38 [PATCH RESEND v3] iio: Add device tree support to LPC32xx ADC Roland Stigge
2012-04-20 15:04 ` Lars-Peter Clausen [this message]
2012-04-20 15:35 ` Roland Stigge
2012-04-20 15:35 ` Roland Stigge
2012-04-20 15:58 ` Arnd Bergmann
2012-04-20 15:58 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F917AE3.7050808@metafoo.de \
--to=lars@metafoo.de \
--cc=devel@driverdev.osuosl.org \
--cc=grant.likely@secretlab.ca \
--cc=gregkh@linuxfoundation.org \
--cc=jic23@cam.ac.uk \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rob.herring@calxeda.com \
--cc=stigge@antcom.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.