All of lore.kernel.org
 help / color / mirror / Atom feed
From: John Stultz <john.stultz@linaro.org>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: Linux Kernel <linux-kernel@vger.kernel.org>,
	Colin Cross <ccross@android.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Android Kernel Team <kernel-team@android.com>
Subject: Re: [PATCH 0/4] Android Alarm Driver Cleanups (for staging-next/3.5)
Date: Fri, 20 Apr 2012 15:57:05 -0700	[thread overview]
Message-ID: <4F91E9C1.4050102@linaro.org> (raw)
In-Reply-To: <20120420220849.GA5642@kroah.com>

On 04/20/2012 03:08 PM, Greg KH wrote:
> On Fri, Apr 20, 2012 at 12:31:43PM -0700, John Stultz wrote:
>> Greg: Would you mind applying this set to staging-next for 3.5?
> It took some messing with (due to some over-eager people fixing spelling
> mistakes and compiler warnings that you didn't have in your tree), but
> I've applied these now.  Thanks for doing this work.
>
> But, as I already said, this patch set produces some big compiler
> warnings, can you please fix them up before I get nasty messages from
> the linux-next maintainer?
Ok. So I manged to trigger the warning at patch 3/4 too. However, patch 
4/4 resolves it.

The problem is the android alarm driver and the alarmtimer code have a 
naming collision with "struct alarm", and there were some macros (see 
CONFIG_ANDROID_ALARM_OLDDRV_COMPAT in staging/android/android_alarm.h 
before these patches) that allow a easier transition over to the new 
code for out of tree drivers.

Ideally I would have yanked those macros in 3/4 instead of 4/4.  But 
after 4/4 is applied the issue should not longer be present (at least 
I've not been able to trigger it)

Do you want me to respin the last two patches?

thanks
-john


  reply	other threads:[~2012-04-20 22:57 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-20 19:31 [PATCH 0/4] Android Alarm Driver Cleanups (for staging-next/3.5) John Stultz
2012-04-20 19:31 ` [PATCH 1/4] android-alarm: Convert ALARM_ELAPSED_REALTIME to use CLOCK_BOOTTIME John Stultz
2012-04-20 19:31 ` [PATCH 2/4] alarmtimer: Provide accessor to alarmtimer rtc device John Stultz
2012-04-20 19:31 ` [PATCH 3/4] android-alarm: Rework alarm-dev.c to use upstreamed alarmtimers John Stultz
2012-04-20 22:02   ` Greg KH
2012-04-20 19:31 ` [PATCH 4/4] android-alarm: Remove unused android alarm in-kernel interfaces John Stultz
2012-04-20 22:08 ` [PATCH 0/4] Android Alarm Driver Cleanups (for staging-next/3.5) Greg KH
2012-04-20 22:57   ` John Stultz [this message]
2012-04-20 23:43     ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F91E9C1.4050102@linaro.org \
    --to=john.stultz@linaro.org \
    --cc=ccross@android.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=kernel-team@android.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.