From mboxrd@z Thu Jan 1 00:00:00 1970 From: Florian Tobias Schandinat Subject: Re: [PATCH 1/2] video: msm: Fix section mismatches in mddi.c Date: Mon, 23 Apr 2012 06:16:55 +0000 Message-ID: <4F94F3D7.5030904@gmx.de> References: <1334256334-8234-1-git-send-email-davidb@codeaurora.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: Received: from mailout-de.gmx.net ([213.165.64.22]:36379 "HELO mailout-de.gmx.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1752539Ab2DWGRB (ORCPT ); Mon, 23 Apr 2012 02:17:01 -0400 In-Reply-To: <1334256334-8234-1-git-send-email-davidb@codeaurora.org> Sender: linux-arm-msm-owner@vger.kernel.org List-Id: linux-arm-msm@vger.kernel.org To: David Brown Cc: Daniel Walker , Bryan Huntsman , linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-fbdev@vger.kernel.org On 04/12/2012 06:45 PM, David Brown wrote: > The change > commit 461cbe77d0a4f887c33a3a95ea68a7daf23b4302 > Author: Gregory Bean > Date: Wed Jul 28 10:22:13 2010 -0700 > > video: msm: Fix section mismatch in mddi.c. > > fixes a section mismatch between the board file and the driver's probe > function, however, it misses the additional mismatches between the > probe function and some routines it calls. Fix these up as well. > > Signed-off-by: David Brown Applied. Thanks, Florian Tobias Schandinat > --- > drivers/video/msm/mddi.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/video/msm/mddi.c b/drivers/video/msm/mddi.c > index 4527cbf..b061d70 100644 > --- a/drivers/video/msm/mddi.c > +++ b/drivers/video/msm/mddi.c > @@ -420,7 +420,7 @@ static void mddi_resume(struct msm_mddi_client_data *cdata) > mddi_set_auto_hibernate(&mddi->client_data, 1); > } > > -static int __init mddi_get_client_caps(struct mddi_info *mddi) > +static int __devinit mddi_get_client_caps(struct mddi_info *mddi) > { > int i, j; > > @@ -622,9 +622,9 @@ uint32_t mddi_remote_read(struct msm_mddi_client_data *cdata, uint32_t reg) > > static struct mddi_info mddi_info[2]; > > -static int __init mddi_clk_setup(struct platform_device *pdev, > - struct mddi_info *mddi, > - unsigned long clk_rate) > +static int __devinit mddi_clk_setup(struct platform_device *pdev, > + struct mddi_info *mddi, > + unsigned long clk_rate) > { > int ret; > From mboxrd@z Thu Jan 1 00:00:00 1970 From: Florian Tobias Schandinat Date: Mon, 23 Apr 2012 06:16:55 +0000 Subject: Re: [PATCH 1/2] video: msm: Fix section mismatches in mddi.c Message-Id: <4F94F3D7.5030904@gmx.de> List-Id: References: <1334256334-8234-1-git-send-email-davidb@codeaurora.org> In-Reply-To: <1334256334-8234-1-git-send-email-davidb@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: linux-arm-kernel@lists.infradead.org On 04/12/2012 06:45 PM, David Brown wrote: > The change > commit 461cbe77d0a4f887c33a3a95ea68a7daf23b4302 > Author: Gregory Bean > Date: Wed Jul 28 10:22:13 2010 -0700 > > video: msm: Fix section mismatch in mddi.c. > > fixes a section mismatch between the board file and the driver's probe > function, however, it misses the additional mismatches between the > probe function and some routines it calls. Fix these up as well. > > Signed-off-by: David Brown Applied. Thanks, Florian Tobias Schandinat > --- > drivers/video/msm/mddi.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/video/msm/mddi.c b/drivers/video/msm/mddi.c > index 4527cbf..b061d70 100644 > --- a/drivers/video/msm/mddi.c > +++ b/drivers/video/msm/mddi.c > @@ -420,7 +420,7 @@ static void mddi_resume(struct msm_mddi_client_data *cdata) > mddi_set_auto_hibernate(&mddi->client_data, 1); > } > > -static int __init mddi_get_client_caps(struct mddi_info *mddi) > +static int __devinit mddi_get_client_caps(struct mddi_info *mddi) > { > int i, j; > > @@ -622,9 +622,9 @@ uint32_t mddi_remote_read(struct msm_mddi_client_data *cdata, uint32_t reg) > > static struct mddi_info mddi_info[2]; > > -static int __init mddi_clk_setup(struct platform_device *pdev, > - struct mddi_info *mddi, > - unsigned long clk_rate) > +static int __devinit mddi_clk_setup(struct platform_device *pdev, > + struct mddi_info *mddi, > + unsigned long clk_rate) > { > int ret; > From mboxrd@z Thu Jan 1 00:00:00 1970 From: FlorianSchandinat@gmx.de (Florian Tobias Schandinat) Date: Mon, 23 Apr 2012 06:16:55 +0000 Subject: [PATCH 1/2] video: msm: Fix section mismatches in mddi.c In-Reply-To: <1334256334-8234-1-git-send-email-davidb@codeaurora.org> References: <1334256334-8234-1-git-send-email-davidb@codeaurora.org> Message-ID: <4F94F3D7.5030904@gmx.de> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 04/12/2012 06:45 PM, David Brown wrote: > The change > commit 461cbe77d0a4f887c33a3a95ea68a7daf23b4302 > Author: Gregory Bean > Date: Wed Jul 28 10:22:13 2010 -0700 > > video: msm: Fix section mismatch in mddi.c. > > fixes a section mismatch between the board file and the driver's probe > function, however, it misses the additional mismatches between the > probe function and some routines it calls. Fix these up as well. > > Signed-off-by: David Brown Applied. Thanks, Florian Tobias Schandinat > --- > drivers/video/msm/mddi.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/video/msm/mddi.c b/drivers/video/msm/mddi.c > index 4527cbf..b061d70 100644 > --- a/drivers/video/msm/mddi.c > +++ b/drivers/video/msm/mddi.c > @@ -420,7 +420,7 @@ static void mddi_resume(struct msm_mddi_client_data *cdata) > mddi_set_auto_hibernate(&mddi->client_data, 1); > } > > -static int __init mddi_get_client_caps(struct mddi_info *mddi) > +static int __devinit mddi_get_client_caps(struct mddi_info *mddi) > { > int i, j; > > @@ -622,9 +622,9 @@ uint32_t mddi_remote_read(struct msm_mddi_client_data *cdata, uint32_t reg) > > static struct mddi_info mddi_info[2]; > > -static int __init mddi_clk_setup(struct platform_device *pdev, > - struct mddi_info *mddi, > - unsigned long clk_rate) > +static int __devinit mddi_clk_setup(struct platform_device *pdev, > + struct mddi_info *mddi, > + unsigned long clk_rate) > { > int ret; >