From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1SMFFX-0008U0-AP for mharc-grub-devel@gnu.org; Mon, 23 Apr 2012 05:07:59 -0400 Received: from eggs.gnu.org ([208.118.235.92]:40422) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SMFFP-0008Sw-Eu for grub-devel@gnu.org; Mon, 23 Apr 2012 05:07:57 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SMFFJ-00044a-OG for grub-devel@gnu.org; Mon, 23 Apr 2012 05:07:51 -0400 Received: from mail-wg0-f49.google.com ([74.125.82.49]:40316) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SMFFJ-00044C-Fw for grub-devel@gnu.org; Mon, 23 Apr 2012 05:07:45 -0400 Received: by wgbdr1 with SMTP id dr1so8596505wgb.30 for ; Mon, 23 Apr 2012 02:07:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:user-agent:mime-version:to:subject:references :in-reply-to:x-enigmail-version:content-type; bh=+PaD1HG9J2hgWwLyxpuGoV0jLGmoOaCMMcct56roW38=; b=FCFYVIrB7wcPM/VEAjlBqP0xzeosJBiV0nauqNLwXhbKlFvj3Z80CxizUCd8w9P+/P 6k7leAyHVfI8ow4XtoB7Br6K5RD8LREzgRVi8Pp/yXQu1Qqu7jE5/HYQtQWFcOc6bK41 /DVNINoDteunrkU+MU32Bmm1BSN8wQNwXc23lC3mBiQQcg8XfhgMFMSSrrq/elwAS+rc 8g4h68JgpcXsoPRW1cY2mftwhHv24biajEbBiWkp0k4in6wiVHdIMInAjbZKh1z2kYW7 4fcUDkr7fRxK+exHep1DYc2d53z7O5wxpXLr6XrOGpPU0joGdAid8y5b9xOygR5SvkDx 5QuQ== Received: by 10.180.78.164 with SMTP id c4mr19477534wix.10.1335172063419; Mon, 23 Apr 2012 02:07:43 -0700 (PDT) Received: from fedora.x201.phnet (111-233.197-178.cust.bluewin.ch. [178.197.233.111]) by mx.google.com with ESMTPS id 6sm21419879wiz.1.2012.04.23.02.07.39 (version=TLSv1/SSLv3 cipher=OTHER); Mon, 23 Apr 2012 02:07:42 -0700 (PDT) Message-ID: <4F951BD2.6070701@gmail.com> Date: Mon, 23 Apr 2012 11:07:30 +0200 From: =?UTF-8?B?VmxhZGltaXIgJ8+GLWNvZGVyL3BoY29kZXInIFNlcmJpbmVua28=?= User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:11.0) Gecko/20120329 Thunderbird/11.0.1 MIME-Version: 1.0 To: grub-devel@gnu.org Subject: Re: [PATCH,HURD] Fix grub-probe with userland partition support References: <20120422182439.GE4755@type.famille.thibault.fr> In-Reply-To: <20120422182439.GE4755@type.famille.thibault.fr> X-Enigmail-Version: 1.4 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="------------enig56B28EDF3C28A36158285487" X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 74.125.82.49 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 23 Apr 2012 09:07:57 -0000 This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig56B28EDF3C28A36158285487 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 22.04.2012 20:24, Samuel Thibault wrote: > + sprintf (devpath + strlen (devpath), "s%d", winner_part + 1); > + } Also: - It's probably wrong to assume that Hurd partition numbering is the same as GRUB's, especially if several partmaps are present. - Don't use x + strlen (x), keep pointer instead, you can easily do it if you replace strcpy with stpcpy - sprintf is banned in GRUB code. Use snprintf --=20 Regards Vladimir '=CF=86-coder/phcoder' Serbinenko --------------enig56B28EDF3C28A36158285487 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iF4EAREKAAYFAk+VG9IACgkQNak7dOguQgl5awD/cF614WgCFhJD7+HdBOcpmzZ/ uXFU/L3mHocPMs8XX+8BALls+7m4p6fhTB7evmFA3Ag+tTmITrGJPYUZxjZwtmuq =p/J9 -----END PGP SIGNATURE----- --------------enig56B28EDF3C28A36158285487--