From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1SMKpK-0002NK-2b for mharc-grub-devel@gnu.org; Mon, 23 Apr 2012 11:05:18 -0400 Received: from eggs.gnu.org ([208.118.235.92]:46337) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SMKpH-0002MV-5F for grub-devel@gnu.org; Mon, 23 Apr 2012 11:05:16 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SMKpB-0007DQ-Ju for grub-devel@gnu.org; Mon, 23 Apr 2012 11:05:14 -0400 Received: from mail-wi0-f177.google.com ([209.85.212.177]:53082) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SMKpB-0007AL-BC for grub-devel@gnu.org; Mon, 23 Apr 2012 11:05:09 -0400 Received: by wibhj13 with SMTP id hj13so2324637wib.12 for ; Mon, 23 Apr 2012 08:05:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:user-agent:mime-version:to:subject:references :in-reply-to:x-enigmail-version:content-type; bh=k/SCyMSN0zyyeGQuq32kG19iqrGIg/CZtKV3GThX9qs=; b=unhaYfYnAYQ76FSQ1xrE0MMx/zaZwyohrkRv+4pm/GqpEdXb4JRNI8btUBNHtEByPu eGNBNSjtgRk+yTd1uDl7KhfbcqjGZ9a0gSMb6zyg08+Ms91gBu+CRplFWoxt70SLdkky Aky5wvVP2OL/P2aptMUy3+z011Tm+aATPLUS5ZIsUOjYVvQEBkJANfHJ0oQ6ZFCpIIdj RqtZU7Po/P8hoz0mxbvjxlhMCAuYKxeDkheYg4+UHzXvA5EaQmYTT/Xu19c95249TBws ar46pv3LNYNt2G9D3oYD8NYWhmsbZhYv0ogP3YndnguSXxPvd1FXPsK3KstDwuNsUDF4 1AbQ== Received: by 10.180.81.166 with SMTP id b6mr22295079wiy.0.1335193507364; Mon, 23 Apr 2012 08:05:07 -0700 (PDT) Received: from debian.x201.phnet (1-234.197-178.cust.bluewin.ch. [178.197.234.1]) by mx.google.com with ESMTPS id j3sm35931777wiw.1.2012.04.23.08.05.04 (version=TLSv1/SSLv3 cipher=OTHER); Mon, 23 Apr 2012 08:05:06 -0700 (PDT) Message-ID: <4F956F96.6030502@gmail.com> Date: Mon, 23 Apr 2012 17:04:54 +0200 From: =?UTF-8?B?VmxhZGltaXIgJ8+GLWNvZGVyL3BoY29kZXInIFNlcmJpbmVua28=?= User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:10.0.3) Gecko/20120329 Icedove/10.0.3 MIME-Version: 1.0 To: grub-devel@gnu.org Subject: Re: [PATCH] bug fix for ntfs References: In-Reply-To: X-Enigmail-Version: 1.4 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="------------enig38E11D1238720CE07FF3B930" X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 209.85.212.177 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 23 Apr 2012 15:05:16 -0000 This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig38E11D1238720CE07FF3B930 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 23.04.2012 16:41, Bean wrote: > Hi all, > > This patch fix three issues: > > 1, In ntfsdoc, it says namespace =3D 0 means POSIX and it's case > sensitive. However, i found out this is not sure in Windows 7 as some > system directory use this value as well. Now i ignore this flag and > treat all files in ntfs as case insensitive. This would be wrong. It's cert=D0=B0inly possible to create files differi= ng only in case in POSIX namespace, so it's case-sensitive. If some system directory uses this namespace it's case-sensitive > 2, Previous version doesn't return blocklist information for small > files embed in MFT, this patch fixes it. For example, create a > 512-byte file test in ntfs and try this command: > > grub-fstest /ntfs.img blocklist /test It looks like this part of patch has issues. Like that it doesn't handle the case when the read is split across 2 sectors or if MFT entry is at offset >=3D1024. Or that it adds some checks (like "invalid mft offset") which weren't there previously and which would make GRUB bail out on weird FS even if user doesn't want blocklists. AFAIR MFT is duplicated and so we can't just overwrite it, also MFT can more easily change place. In such cases we intentionally skip the blocklists (like we do for ZFS and BtrFS). In any case I feel like this part shouldn't go it until after 2.00 as it doesn't fix any end-user problem (blocklists for embed files would be rejected by any of blocklist users, other than blocklist command) and it may cause new problems. > 3, Missing break in switch statement in grub-fstest Will commit this part shortly. > > > _______________________________________________ > Grub-devel mailing list > Grub-devel@gnu.org > https://lists.gnu.org/mailman/listinfo/grub-devel --=20 Regards Vladimir '=CF=86-coder/phcoder' Serbinenko --------------enig38E11D1238720CE07FF3B930 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iF4EAREKAAYFAk+Vb58ACgkQNak7dOguQgk/zwEAreq8xJfQRZR9VItA/FMcN5wL jyU5dRZIR1C8ORZ8Ad0A/2l2yjjILH/LhQi7KfMndb17gvdpz7SMtHZdZN+XQ0jd =8Nqq -----END PGP SIGNATURE----- --------------enig38E11D1238720CE07FF3B930--