All of lore.kernel.org
 help / color / mirror / Atom feed
From: Darren Hart <dvhart@linux.intel.com>
To: Patches and discussions about the oe-core layer
	<openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH] bootimg.bbclass: Tweak iso images to become hybrid images
Date: Mon, 23 Apr 2012 08:37:15 -0700	[thread overview]
Message-ID: <4F95772B.2080007@linux.intel.com> (raw)
In-Reply-To: <1334872962.3028.2.camel@ted>



On 04/19/2012 03:02 PM, Richard Purdie wrote:
> From: Damien Lespiau <damien.lespiau@intel.com>
> 
> This allows iso images to be written to usb keys and booted on systems which
> have a BIOS which support this. There is no real down side to tweaking the iso
> images in this way.

I like the idea, but there does appear to be one potential downside.
From the syslinux isolinux.txt documentation:

"The ISO 9660 filesystem is encapsulated in a partition (which starts
at offset zero, which may confuse some systems.)"

How many different systems and firmware has this been tested on?

I think it is a worthwhile patch, but we should be aware of the above in
case a regression is reported. In such an event, it seems a
NO_ISO_HYBRID flag could be set by the machine.conf to revert to the
older behavior.

--
Darren

> 
> [YOCTO #1763 partial]
> 
> Signed-off-by: Damien Lespiau <damien.lespiau@intel.com>
> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
> ---
> diff --git a/meta/classes/bootimg.bbclass b/meta/classes/bootimg.bbclass
> index f4981d8..370b378 100644
> --- a/meta/classes/bootimg.bbclass
> +++ b/meta/classes/bootimg.bbclass
> @@ -103,6 +103,8 @@ build_iso() {
>  			-r ${ISODIR}
>  	fi
>  
> +	isohybrid ${DEPLOY_DIR_IMAGE}/${IMAGE_NAME}.iso
> +
>  	cd ${DEPLOY_DIR_IMAGE}
>  	rm -f ${DEPLOY_DIR_IMAGE}/${IMAGE_LINK_NAME}.iso
>  	ln -s ${IMAGE_NAME}.iso ${DEPLOY_DIR_IMAGE}/${IMAGE_LINK_NAME}.iso
> 
> 
> 
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core

-- 
Darren Hart
Intel Open Source Technology Center
Yocto Project - Linux Kernel



  reply	other threads:[~2012-04-23 15:47 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-19 22:02 [PATCH] bootimg.bbclass: Tweak iso images to become hybrid images Richard Purdie
2012-04-23 15:37 ` Darren Hart [this message]
2012-04-23 17:14   ` Otavio Salvador
2012-04-24  8:47   ` Richard Purdie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F95772B.2080007@linux.intel.com \
    --to=dvhart@linux.intel.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.