From mboxrd@z Thu Jan  1 00:00:00 1970
From: Martin Peres <martin.peres@free.fr>
Subject: Re: [RFC PATCH 5/5] drm/nouveau: gpu lockup recovery
Date: Mon, 23 Apr 2012 18:46:41 +0200
Message-ID: <4F958771.6040008@free.fr>
References: <1335133112-8008-5-git-send-email-marcin.slusarz@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="iso-8859-1"; Format="flowed"
Content-Transfer-Encoding: quoted-printable
Return-path: <dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org>
Received: from smtp6-g21.free.fr (smtp6-g21.free.fr [212.27.42.6])
	by gabe.freedesktop.org (Postfix) with ESMTP id 466C79F373
	for <dri-devel@lists.freedesktop.org>;
	Mon, 23 Apr 2012 09:50:47 -0700 (PDT)
In-Reply-To: <1335133112-8008-5-git-send-email-marcin.slusarz@gmail.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/dri-devel>,
	<mailto:dri-devel-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/dri-devel>
List-Post: <mailto:dri-devel@lists.freedesktop.org>
List-Help: <mailto:dri-devel-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/dri-devel>,
	<mailto:dri-devel-request@lists.freedesktop.org?subject=subscribe>
Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org
Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org
To: dri-devel@lists.freedesktop.org
List-Id: dri-devel@lists.freedesktop.org

Hey,

Just a minor mistake spotted while skimming through the patch.

Le 23/04/2012 00:18, Marcin Slusarz a =E9crit :
> +static inline uint64_t nv_timeout(struct drm_device *dev)
> +{
> +	uint64_t tm =3D 2000000000ULL;
> +	if (nouveau_gpu_reset_in_progress(dev))
> +		tm /=3D 40; /* 50ms */
This will cause a problem on 32 bit kernels. You should use do_div.

Martin