From: "Franky Lin" <frankyl@broadcom.com>
To: "Johannes Berg" <johannes@sipsolutions.net>,
"Florian Fainelli" <florian@openwrt.org>,
linville@tuxdriver.com
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH 3.4 1/2] brcm80211: fmac: fix SDIO function 0 register r/w issue
Date: Mon, 23 Apr 2012 10:45:14 -0700 [thread overview]
Message-ID: <4F95952A.7020001@broadcom.com> (raw)
In-Reply-To: <1335171007.3928.9.camel@jlt3.sipsolutions.net>
On 04/23/2012 01:50 AM, Johannes Berg wrote:
> On Mon, 2012-04-23 at 10:45 +0200, Florian Fainelli wrote:
>
>>> } else if (regaddr == SDIO_CCCR_ABORT) {
>>> + sdfunc = kzalloc(sizeof(struct sdio_func), GFP_KERNEL);
>>
>> You are not catching a kzalloc() possible failure here.
>>
>>> + memcpy(sdfunc, sdiodev->func[0], sizeof(struct sdio_func));
>
> and it should probably be kmemdup anyway?
>
> johannes
>
Thx Florian and Johannes, I will send out a V2.
Franky
next prev parent reply other threads:[~2012-04-23 17:45 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-20 21:27 [PATCH 3.4 0/2] brcm80211: two fullmac bug fix for 3.4 Franky Lin
2012-04-20 21:27 ` [PATCH 3.4 1/2] brcm80211: fmac: fix SDIO function 0 register r/w issue Franky Lin
2012-04-23 8:45 ` Florian Fainelli
2012-04-23 8:50 ` Johannes Berg
2012-04-23 17:45 ` Franky Lin [this message]
2012-04-20 21:27 ` [PATCH 3.4 2/2] brcm80211: fmac: fix missing completion events issue Franky Lin
2012-04-23 21:24 ` [PATCH 3.4 V2 0/2] brcm80211: two fullmac bug fix for 3.4 Franky Lin
2012-04-23 21:24 ` [PATCH 3.4 V2 1/2] brcm80211: fmac: fix SDIO function 0 register r/w issue Franky Lin
2012-04-23 21:24 ` [PATCH 3.4 V2 2/2] brcm80211: fmac: fix missing completion events issue Franky Lin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F95952A.7020001@broadcom.com \
--to=frankyl@broadcom.com \
--cc=florian@openwrt.org \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.