From: John Crispin <blogic-p3rKhJxN3npAfugRpC6u6w@public.gmane.org>
To: Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
Cc: devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org
Subject: Re: [PATCH] pinctrl: add error message to pinmux_map_to_setting's error path
Date: Mon, 23 Apr 2012 20:49:34 +0200 [thread overview]
Message-ID: <4F95A43E.9000005@openwrt.org> (raw)
In-Reply-To: <4F95A162.3080200-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
> There are some other cases where more error messages would be useful,
> such as invalid function name, invalid config options etc. I was
> planning on going through the code and adding these since some of these
> are hitting me on a new board I'm adding to mainline. Are you planning
> to add more of these messages, or should I go ahead with that?
I am in the process of converting the mips/lantiq/ target to OF and
pinctrl amongst over things.
i stumbled across the 2 patches i mailed today. i will be able to spare
a couple of hours tomorrow
to see if i can find more places where debug output would make sense.
> I wonder if the message would be more useful if it said something like
> "invalid group %s for function %s" - that would give a little more
> information for the user to track down the incorrect entry, since that
> group name may be valid in general, just not for the function being
> converted.
that is the case. lets see what i can come up with.
> BTW, the "Cc" you added to the commit description doesn't appear to be
> happening; I'm only receiving this message through the list.
I realized this aswell, although i am subscribed to the list (even
checked if i subscribed with this mail addr) .
i will check the server logs and contact the list admins to see whats up
prev parent reply other threads:[~2012-04-23 18:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-23 17:40 [PATCH] pinctrl: add error message to pinmux_map_to_setting's error path John Crispin
[not found] ` <1335202806-19520-1-git-send-email-blogic-p3rKhJxN3npAfugRpC6u6w@public.gmane.org>
2012-04-23 18:37 ` Stephen Warren
[not found] ` <4F95A162.3080200-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2012-04-23 18:49 ` John Crispin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F95A43E.9000005@openwrt.org \
--to=blogic-p3rkhjxn3npafugrpc6u6w@public.gmane.org \
--cc=devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org \
--cc=swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.