Re: [PATCH] v4l: aptina-pll: Round up minimum multiplier factor value properly

[Sakari Ailus <sakari.ailus@iki.fi>]

Hi Laurent,

Laurent Pinchart wrote:
> The mf_low value must be a multiple of mf_inc. Round it up to the
> nearest mf_inc multiple after computing it.
>
> Signed-off-by: Laurent Pinchart<laurent.pinchart@ideasonboard.com>

Thanks!

Acked-by: Sakari Ailus <sakari.ailus@iki.fi>

> ---
>   drivers/media/video/aptina-pll.c |    5 ++---
>   1 files changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/media/video/aptina-pll.c b/drivers/media/video/aptina-pll.c
> index 0bd3813..8153a44 100644
> --- a/drivers/media/video/aptina-pll.c
> +++ b/drivers/media/video/aptina-pll.c
> @@ -148,9 +148,8 @@ int aptina_pll_calculate(struct device *dev,
>   		unsigned int mf_high;
>   		unsigned int mf_low;
>
> -		mf_low = max(roundup(mf_min, mf_inc),
> -			     DIV_ROUND_UP(pll->ext_clock * p1,
> -			       limits->int_clock_max * div));
> +		mf_low = roundup(max(mf_min, DIV_ROUND_UP(pll->ext_clock * p1,
> +					limits->int_clock_max * div)), mf_inc);
>   		mf_high = min(mf_max, pll->ext_clock * p1 /
>   			      (limits->int_clock_min * div));
>


-- 
Sakari Ailus
sakari.ailus@iki.fi