From: Jonathan Cameron <jic23@kernel.org>
To: Maxime Ripard <maxime.ripard@free-electrons.com>
Cc: linux-iio@vger.kernel.org
Subject: Re: [RFC] Add frequency support in trigger core
Date: Tue, 24 Apr 2012 09:12:38 +0100 [thread overview]
Message-ID: <4F966076.2070402@kernel.org> (raw)
In-Reply-To: <1334851538-21408-1-git-send-email-maxime.ripard@free-electrons.com>
On 4/19/2012 5:05 PM, Maxime Ripard wrote:
> Hi List,
>
> A lot of driver add an extra frequency attribute to allow user to tune
> triggers frequency from sysfs. This is a lot of code duplication, while most
> do the exact same thing.
>
> I added here two extra fields to struct iio_trigger, frequency and info_mask,
> which might not be needed at first, but will allow us to add extra parameters
> more easily.
>
> I added as well a callback for info_mask changes in trigger_ops so that drivers
> can take action when frequency has been changed by the user, but will also be
> easily extendable.
I'm generally in favour of this as it'll make in kernel accesses to
these controls easier to add.
prev parent reply other threads:[~2012-04-24 8:12 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-19 16:05 [RFC] Add frequency support in trigger core Maxime Ripard
2012-04-19 16:05 ` [PATCH 1/2] IIO: Add frequency sysfs files to triggers Maxime Ripard
2012-04-24 8:19 ` Jonathan Cameron
2012-04-26 13:48 ` Maxime Ripard
2012-04-19 16:05 ` [PATCH 2/2] Move RTC trigger to in-core frequency support Maxime Ripard
2012-04-24 8:22 ` Jonathan Cameron
2012-04-24 8:36 ` Maxime Ripard
2012-04-24 9:10 ` Jonathan Cameron
2012-04-24 8:12 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F966076.2070402@kernel.org \
--to=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=maxime.ripard@free-electrons.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.