From mboxrd@z Thu Jan 1 00:00:00 1970 From: Xiao Guangrong Subject: Re: [PATCH RFC] KVM: MMU: Don't use RCU for lockless shadow walking Date: Tue, 24 Apr 2012 18:05:59 +0800 Message-ID: <4F967B07.4030204@linux.vnet.ibm.com> References: <1335197812-32064-1-git-send-email-avi@redhat.com> <4F964A2C.7050106@linux.vnet.ibm.com> <4F96703F.4000607@redhat.com> <4F967870.6080806@linux.vnet.ibm.com> <4F967A18.8030303@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Cc: Marcelo Tosatti , kvm@vger.kernel.org To: Avi Kivity Return-path: Received: from e23smtp05.au.ibm.com ([202.81.31.147]:39007 "EHLO e23smtp05.au.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756600Ab2DXKGH (ORCPT ); Tue, 24 Apr 2012 06:06:07 -0400 Received: from /spool/local by e23smtp05.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 24 Apr 2012 10:01:22 +1000 Received: from d23av01.au.ibm.com (d23av01.au.ibm.com [9.190.234.96]) by d23relay04.au.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id q3O9xJKt2056432 for ; Tue, 24 Apr 2012 19:59:19 +1000 Received: from d23av01.au.ibm.com (loopback [127.0.0.1]) by d23av01.au.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id q3OA61O0023589 for ; Tue, 24 Apr 2012 20:06:01 +1000 In-Reply-To: <4F967A18.8030303@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On 04/24/2012 06:02 PM, Avi Kivity wrote: >> >> kvm_vcpu_exiting_guest_mode(vcpu) != OUTSIDE_GUEST_MODE) >> cpumask_set_cpu(cpu, cpus); >> } >> >> VCPU 0 send IPI to CPU1, but actually, VCPU1 is running on CPU 2. >> > > It can happen, but it's benign. After migration, vcpu1 will examine > vcpu->requests and flush the TLB. > Yes, you are right, i forgot it.