From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from eu1sys200aog102.obsmtp.com ([207.126.144.113]:56469 "EHLO eu1sys200aog102.obsmtp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752306Ab2DXKg4 (ORCPT ); Tue, 24 Apr 2012 06:36:56 -0400 Message-ID: <4F9681D4.9010904@st.com> Date: Tue, 24 Apr 2012 16:05:00 +0530 From: Viresh Kumar MIME-Version: 1.0 To: Marc Zyngier Cc: "wim@iguana.be" , spear-devel , "viresh.linux@gmail.com" , "linux-watchdog@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , Pawel Moll Subject: Re: [PATCH V3 2/2] watchdog: mpcore: Add DT probing support for ARM mpcore watchdog References: <31b0b89e21e6a234cb904761a1d0e5106405da82.1335246446.git.viresh.kumar@st.com> <27dea103ccf6da5b7376c837d9a95dc7a9ed3be3.1335246446.git.viresh.kumar@st.com> <4F9671D8.4080308@arm.com> In-Reply-To: <4F9671D8.4080308@arm.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Sender: linux-watchdog-owner@vger.kernel.org List-Id: linux-watchdog@vger.kernel.org On 4/24/2012 2:56 PM, Marc Zyngier wrote: > I'm sorry, but I really have to ask: What is the point of adding DT > support to this driver when it is obvious that it is already broken? Interrupt is only for testing. And that's why it worked for me earlier, as i didn't passed irq from DT. So, i believe this patch still makes sense. Obviously we can have another patch to get interrupts fixed. -- viresh From mboxrd@z Thu Jan 1 00:00:00 1970 From: viresh.kumar@st.com (Viresh Kumar) Date: Tue, 24 Apr 2012 16:05:00 +0530 Subject: [PATCH V3 2/2] watchdog: mpcore: Add DT probing support for ARM mpcore watchdog In-Reply-To: <4F9671D8.4080308@arm.com> References: <31b0b89e21e6a234cb904761a1d0e5106405da82.1335246446.git.viresh.kumar@st.com> <27dea103ccf6da5b7376c837d9a95dc7a9ed3be3.1335246446.git.viresh.kumar@st.com> <4F9671D8.4080308@arm.com> Message-ID: <4F9681D4.9010904@st.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 4/24/2012 2:56 PM, Marc Zyngier wrote: > I'm sorry, but I really have to ask: What is the point of adding DT > support to this driver when it is obvious that it is already broken? Interrupt is only for testing. And that's why it worked for me earlier, as i didn't passed irq from DT. So, i believe this patch still makes sense. Obviously we can have another patch to get interrupts fixed. -- viresh