From: Marc Kleine-Budde <mkl@pengutronix.de>
To: "AnilKumar, Chimata" <anilkumar@ti.com>
Cc: "wg@grandegger.com" <wg@grandegger.com>,
"linux-can@vger.kernel.org" <linux-can@vger.kernel.org>,
"Gole, Anant" <anantgole@ti.com>, "Nori, Sekhar" <nsekhar@ti.com>
Subject: Re: [PATCH 1/3] can: c_can: fix "BUG! echo_skb is occupied!" during transmit
Date: Tue, 24 Apr 2012 13:28:07 +0200 [thread overview]
Message-ID: <4F968E47.7020109@pengutronix.de> (raw)
In-Reply-To: <331ABD5ECB02734CA317220B2BBEABC13E997D11@DBDE01.ent.ti.com>
[-- Attachment #1: Type: text/plain, Size: 1908 bytes --]
On 04/24/2012 01:24 PM, AnilKumar, Chimata wrote:
> On Tue, Apr 24, 2012 at 13:25:25, Marc Kleine-Budde wrote:
>> On 04/20/2012 11:57 AM, AnilKumar Ch wrote:
>>> This patch fixes an issue with transmit routine, which causes
>>> "can_put_echo_skb: BUG! echo_skb is occupied!" messgae when
>>> using "cansequence -p" on D_CAN controller.
>>>
>>> In c_can driver, while transmitting packets tx_echo flag holds
>>> the no of can frames put for transmission into the hardware.
>>>
>>> As the comment above c_can_do_tx() indicates, if we find any packet
>>> which is not transmitted then we should stop looking for more.
>>> In the current implementation this is not taken care of causing the
>>> said message.
>>>
>>> Also, fix the condition used to find if the packet is transmitted
>>> or not. Current code skips the first tx message object and ends up
>>> checking one extra invalid object.
>>
>> The two above listed issues can occur with the c_can hardware, too?
>> Please split into two separate patches. These should go to the stable
>> kernel, too. Can someone with a c_can hardware test these patches.
>
> I will split into two patches. I had clubbed both the changes in a single
> patch because both the changes are required to get rid of the error mentioned
> in the subject line.
okay - then it's better to keep them together.
> I will add the stable tag when submitting next, but since I do not have c_can
> hardware, someone needs to confirm this actually solves a c_can issue. I have
> read through the c_can specification and see that this would indeed be a problem
> on c_can.
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions | Phone: +49-231-2826-924 |
Vertretung West/Dortmund | Fax: +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 262 bytes --]
next prev parent reply other threads:[~2012-04-24 11:28 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-20 9:57 [PATCH 1/3] can: c_can: fix "BUG! echo_skb is occupied!" during transmit AnilKumar Ch
2012-04-24 7:55 ` Marc Kleine-Budde
2012-04-24 11:24 ` AnilKumar, Chimata
2012-04-24 11:28 ` Marc Kleine-Budde [this message]
2012-04-24 11:53 ` AnilKumar, Chimata
2012-04-24 13:11 ` Marc Kleine-Budde
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F968E47.7020109@pengutronix.de \
--to=mkl@pengutronix.de \
--cc=anantgole@ti.com \
--cc=anilkumar@ti.com \
--cc=linux-can@vger.kernel.org \
--cc=nsekhar@ti.com \
--cc=wg@grandegger.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.