Re: [PATCH] xen_disk: remove syncwrite option

[Kevin Wolf <kwolf@redhat.com>]

Am 24.04.2012 13:22, schrieb Stefano Stabellini:
> Use the BDRV_O_CACHE_* flags instead.
> 
> Signed-off-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>

Doesn't apply to qemu.git because...

> ---
>  hw/xen_disk.c |    8 +-------
>  1 files changed, 1 insertions(+), 7 deletions(-)
> 
> diff --git a/hw/xen_disk.c b/hw/xen_disk.c
> index 4a6d89c..3e4a47b 100644
> --- a/hw/xen_disk.c
> +++ b/hw/xen_disk.c
> @@ -48,7 +48,6 @@
>  
>  /* ------------------------------------------------------------- */
>  
> -static int syncwrite    = 0;
>  static int batch_maps   = 0;
>  
>  static int max_requests = 32;
> @@ -189,15 +188,10 @@ static int ioreq_parse(struct ioreq *ioreq)
>              ioreq->presync = 1;
>              return 0;
>          }
> -        if (!syncwrite) {
> -            ioreq->postsync = 1;

...this is ioreq->presync = ioreq->postsync = 1;

And while we're at it, the commit message could mention that there was
no way to set this flag anyway, so we're just removing dead code.

Kevin