From: Sergei Shtylyov <sshtylyov@mvista.com>
To: Viresh Kumar <viresh.kumar@st.com>
Cc: Andrew Lunn <andrew@lunn.ch>,
"akpm@linux-foundation.org" <akpm@linux-foundation.org>,
"linux@arm.linux.org.uk" <linux@arm.linux.org.uk>,
spear-devel <spear-devel@list.st.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-ide@vger.kernel.org" <linux-ide@vger.kernel.org>,
"viresh.linux@gmail.com" <viresh.linux@gmail.com>,
"mturquette@linaro.org" <mturquette@linaro.org>,
"jgarzik@redhat.com" <jgarzik@redhat.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH V2 4/9] ata/sata_mv: Remove conditional compilation of clk code
Date: Tue, 24 Apr 2012 16:04:22 +0400 [thread overview]
Message-ID: <4F9696C6.1080404@mvista.com> (raw)
In-Reply-To: <4F9650B3.9030406@st.com>
Hello.
On 24-04-2012 11:05, Viresh Kumar wrote:
>> I don't think this change is correct. With the old semantics, it was:
> Sorry. :(
>> If we have CLK support, we expect there to be a clock for sata_mv, and
>> if there is no such clock, output a notice message, something is
>> probably wrong, i expected there to be a clock.
>> The new semantics are:
>> We expect there to be a clock for sata_mv, and if there is no such
>> clock, output a notice message, something is probably wrong, i
>> expected there to be a clock.
>> We are going to see this notice message much more, when it is not
>> expected.
> So, the only problem is this message?
> How do you suggest to tackle this now. Have #ifdef,#endif around this print?
When there's no CONFIG_HAVE_CLK, if clk_get() returns NULL, not error,
there'll be no message.
WBR, Sergei
WARNING: multiple messages have this Message-ID (diff)
From: sshtylyov@mvista.com (Sergei Shtylyov)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH V2 4/9] ata/sata_mv: Remove conditional compilation of clk code
Date: Tue, 24 Apr 2012 16:04:22 +0400 [thread overview]
Message-ID: <4F9696C6.1080404@mvista.com> (raw)
In-Reply-To: <4F9650B3.9030406@st.com>
Hello.
On 24-04-2012 11:05, Viresh Kumar wrote:
>> I don't think this change is correct. With the old semantics, it was:
> Sorry. :(
>> If we have CLK support, we expect there to be a clock for sata_mv, and
>> if there is no such clock, output a notice message, something is
>> probably wrong, i expected there to be a clock.
>> The new semantics are:
>> We expect there to be a clock for sata_mv, and if there is no such
>> clock, output a notice message, something is probably wrong, i
>> expected there to be a clock.
>> We are going to see this notice message much more, when it is not
>> expected.
> So, the only problem is this message?
> How do you suggest to tackle this now. Have #ifdef,#endif around this print?
When there's no CONFIG_HAVE_CLK, if clk_get() returns NULL, not error,
there'll be no message.
WBR, Sergei
next prev parent reply other threads:[~2012-04-24 12:04 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-24 7:04 [PATCH V2 4/9] ata/sata_mv: Remove conditional compilation of clk code Andrew Lunn
2012-04-24 7:04 ` Andrew Lunn
2012-04-24 7:05 ` Viresh Kumar
2012-04-24 7:05 ` Viresh Kumar
2012-04-24 7:26 ` Andrew Lunn
2012-04-24 7:26 ` Andrew Lunn
2012-04-24 7:42 ` Russell King - ARM Linux
2012-04-24 7:42 ` Russell King - ARM Linux
2012-04-24 7:58 ` Viresh Kumar
2012-04-24 7:58 ` Viresh Kumar
2012-04-24 8:26 ` Russell King - ARM Linux
2012-04-24 8:26 ` Russell King - ARM Linux
2012-04-24 8:30 ` Viresh Kumar
2012-04-24 8:30 ` Viresh Kumar
2012-04-24 12:04 ` Sergei Shtylyov [this message]
2012-04-24 12:04 ` Sergei Shtylyov
-- strict thread matches above, loose matches on Subject: below --
2012-04-24 5:56 [PATCH V2 0/9] clk: Add non CONFIG_HAVE_CLK routines Viresh Kumar
2012-04-24 5:56 ` [PATCH V2 4/9] ata/sata_mv: Remove conditional compilation of clk code Viresh Kumar
2012-04-24 5:56 ` Viresh Kumar
2012-04-24 5:56 ` Viresh Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F9696C6.1080404@mvista.com \
--to=sshtylyov@mvista.com \
--cc=akpm@linux-foundation.org \
--cc=andrew@lunn.ch \
--cc=jgarzik@redhat.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=mturquette@linaro.org \
--cc=spear-devel@list.st.com \
--cc=viresh.kumar@st.com \
--cc=viresh.linux@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.