All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bob W <bob.news@non-elite.com>
To: Konstantin Dimitrov <kosio.dimitrov@gmail.com>
Cc: "Christian Prähauser" <cpraehaus@cosy.sbg.ac.at>,
	linux-media@vger.kernel.org, "Marek Ochaba" <ochaba@maindata.sk>
Subject: Re: DVB-S2 multistream support
Date: Tue, 24 Apr 2012 17:18:15 -0500	[thread overview]
Message-ID: <4F9726A7.4060208@non-elite.com> (raw)
In-Reply-To: <CAF0Ff2=nfGA_jWc4tLnun792C1PN0rZHkGhY=uJz8YHCsFnvKA@mail.gmail.com>



Hi all,

  in playing with these patches, I am noticing the bbframes are only
partially being delivered by the hardware.  I am only getting the first
188 bytes of the frame.

I think it is related to the programming of the saa716xx.

In this function:  saa716x_dma_start the params stuct is filled out,
with 188 in the samples and pitch elements..

does anyone know a little more about this saa716x and how to program
it correctly to receive more data to account for the big bbframes?

thanks

Bob




On 3/19/2012 10:19 AM, Konstantin Dimitrov wrote:
> hello Christian,
> 
> first of all thank you for the great work. so, i have few follow-ups about it:
> 
> 1. since your current patch contains patches that are kernel-specific
> changes (i.e. some general changes to the V4L code for the kernel you
> use), changes related to the BBFrame-support and hardware-specific
> changes (i.e. related to the TBS 6925 card, which at the moment is the
> only affordable hardware at least i know that can handle BBFrames) in
> order for more easy use in different kernels as well for the purpose
> of others to review the changes related to the BBFrame-support in V4L
> 'dvb-core' i split your patch to 3 separate patches (they are attached
> to this email):
> 
> - 01-bb-dmx.patch : it's supposed to contains all changes you made to
> the demux part of V4L 'dvb-core' - i didn't make any further changes -
> just collected your original changes in the patch; it should apply
> clean to all recent kernel released in the last several months (i
> believe at least in the last 6 months), because no changes in this
> parts of 'dvb-core' were made recently
> 
> - 02-bb-fe.patch : those are changes for BBFrame-support related to
> the frontend - i separated those changes and i didn't include them in
> '01-bb-dmx.patch', because recently a lot of changes were made to that
> part of V4L. so, this patch will apply clean to
> "tbs-linux-drivers_v120206" and to other V4L trees most probably it
> will require to manually apply the changes to the respective files,
> but since it changes less than 10 lines in only 3 files that's just
> fine for manual patching
> 
> - 03-bb-tbs.patch : those are all changes specific to the TBS 6925
> hardware. additionally to your changes i defined "tsout" module
> parameter to both 'stv090x' and 'saa716x_tbs-dvb' - that's convenient
> to change between TS and BB mode just with reloading the modules with
> rmmod/modprobe
> 
> 2. so i used the above 3 patches with "tbs-linux-drivers_v120206" and
> after i applied them:
> 
> # cd linux-tbs-drivers
> # patch -p1 < ../01-bb-dmx.patch
> # patch -p1 < ../02-bb-fe.patch
> # patch -p1 < ../03-bb-tbs.patch
> 
> the driver builds successfully, but i'm not sure if i didn't miss
> something from your original patch. also, i put file called
> 'tbs6925.conf' in /etc/modprobe.d with lines in it:
> 
> options stv090x tsout=0
> options saa716x_tbs-dvb tsout=0
> 
> for easy enable/disable of the BB mode with just reloading the modules
> in order to make the testing easier.
> 
> 3. so on the test i did every few seconds i get the following errors:
> 
> _dvb_dmx_swfilter_bbframe: invalid use of reserved TS/GS value 1
> 
> _dvb_dmx_swfilter_bbframe: invalid data field length (length 0, left 10)
> 
> and hex-dump of the BBFrame data. is that supposed to happen? please,
> can you confirm if it happens or not in your environment with your
> original patch or i messed-up something when i prepared the 3 patches
> from point 1. so, that request is in relation to my seconds request -
> please, review the 3 patches from point 1 and confirm they are correct
> and i didn't miss anything - if they are correct patch 01 and 02 can
> be used for review of the code.
> 
> many thanks,
> konstantin
> 


      reply	other threads:[~2012-04-24 23:09 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-12-25  1:06 DVB-S2 multistream support Georgi Chorbadzhiyski
2011-12-25  8:23 ` Antti Palosaari
2011-12-25 10:17   ` Mauro Carvalho Chehab
2011-12-25 10:55     ` Konstantin Dimitrov
2011-12-25 11:18       ` Mauro Carvalho Chehab
2011-12-25 12:37         ` Konstantin Dimitrov
2011-12-27 10:12         ` Christian Prähauser
2011-12-27 16:08           ` Antti Palosaari
2012-01-19 13:34           ` Marek Ochaba
2012-01-21 10:29             ` Christian Prähauser
2012-01-23 13:58               ` Marek Ochaba
2012-01-22  2:13           ` Mauro Carvalho Chehab
2012-01-22 12:44             ` Christian Prähauser
     [not found]           ` <CAF0Ff2mf0tYs3UG3M6Cahep+_kMToVaGgPhTqR7zhRG0UXWuig@mail.gmail.com>
     [not found]             ` <85A7A8FC-150C-4463-B09C-85EED6F851A8@cosy.sbg.ac.at>
     [not found]               ` <CAF0Ff2ncv0PJWSOOw=7WeGyqX3kKiQitY52uEOztfC8Bwj6LgQ@mail.gmail.com>
2012-01-25 13:12                 ` Christian Prähauser
2012-02-01 18:49                   ` Konstantin Dimitrov
2012-02-18 19:06                     ` Christian Prähauser
2012-02-19 23:12                       ` Konstantin Dimitrov
2012-03-07 16:33                         ` Bob Winslow
2012-03-13  9:36                           ` Marek Ochaba
2012-03-13 12:30                             ` Bob W
2012-03-13 15:22                           ` Konstantin Dimitrov
2012-03-13 15:47                             ` Bob W
2012-03-15  9:40                               ` Christian Prähauser
2012-03-19  8:46                                 ` Christian Prähauser
2012-03-19 15:19                                   ` Konstantin Dimitrov
2012-04-24 22:18                                     ` Bob W [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F9726A7.4060208@non-elite.com \
    --to=bob.news@non-elite.com \
    --cc=cpraehaus@cosy.sbg.ac.at \
    --cc=kosio.dimitrov@gmail.com \
    --cc=linux-media@vger.kernel.org \
    --cc=ochaba@maindata.sk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.